New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EPH and Canonicalization #217

Merged

offbyone merged 42 commits into main from canonicalize

Feb 16, 2025

Contributor

offbyone commented Feb 6, 2025 •

edited

Loading

Credit where it's due; this is mostly a port of the EPH logic from Glasgow in 2024, as written by @djm4. You can find that here

This comes with rudimentary tests.

Fixes: #199

offbyone added 18 commits

February 5, 2025 20:31


          Initialize the canonicalize application


          Add the initial model for the Work and WorkNominations

388036e


          Start setting up testing

6a6dbd8

Issue: Issue: #199
Milestone: Seattle 2025 Nominations Close


          WIP: iterating towards EPH support

Issue: Issue: #199
Milestone: Seattle 2025 Nominations Close


          Implement eph ballot tallying for 2025

cdedb53

This is based heavily on the typescript implementation by @djm4 for
Glasgow.

Issue: Issue: #199
Milestone: Seattle 2025 Nominations Close


          lint: ignore unused imports in the app templates

66c06cc

Issue: #199
Milestone: Seattle 2025 Nominations Close


          Timing for EPH on 1500 ballots.

fe2cba1

Issue: Issue: #199
Milestone: Seattle 2025 Nominations Close


          Simplify the schema for works.

a2aadb4

Drop the view of the ballot; we will probably synthesize them from the
data, via joins, rather than resolving them.

Issue: #199
Milestone: Seattle 2025 Nominations Close


          Merge remote-tracking branch 'origin/main' into canonicalize

849e0be


          Initial view for associating the nominations with works

2ca74c6

Issue: #199
Milestone: Seattle 2025 Nominations Close


          Cross-app: add a work property to the nomination

e431ea3

Issue: #199
Milestone: Seattle 2025 Nominations Close


          dev: helper command to generate fake nomination testing data

84417cc

Issue: #199
Milestone: Seattle 2025 Nominations Close


          nominate: provide a proposed work name on nominations

9651c2d

Issue: #199
Milestone: Seattle 2025 Nominations Close


          feat: add a canonicalization admin view

a67c171

The admin view offers a pair of admin interfaces: One to manage the
association between works and nominations, and the other to edit the
details of the work

Issue: #199
Milestone: Seattle 2025 Nominations Close


          Template: integrate the django admin form app

3ea2e4b

Issue: #199
Milestone: Seattle 2025 Nominations Close


          Template: integrate the django admin form app

30e4168

Issue: #199
Milestone: Seattle 2025 Nominations Close


          ui: show associated nominations in the work change form

1084b0c

Issue: #199
Milestone: Seattle 2025 Nominations Close


          perf: prefetch the nomination category and nominator

f674340

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone temporarily deployed to release-pypi

February 12, 2025 03:11

— with

GitHub Actions Inactive


          Create a command to import a nomination dump

13e53e3

`import_nominations` imports a valid nomination dump from NomNom and
_partially_ anonymizes it; it is not anonymous enough to share, but
it does at least file the serial numbers off.

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone changed the title ~~Implement EPH ballot construction~~ Implement EPH and Canonicalization

offbyone force-pushed the canonicalize branch 2 times, most recently from f905a48 to 044e529 Compare

February 12, 2025 05:49


          Force tests to run on Python 3.13

66ee062

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone force-pushed the canonicalize branch from 044e529 to 66ee062 Compare

February 12, 2025 05:50

offbyone temporarily deployed to release-pypi

February 12, 2025 06:00

— with

GitHub Actions Inactive

offbyone added 4 commits

February 11, 2025 22:53


          ui: change nominations tostr to the text of the nomination

e6b5908

Issue: #199
Milestone: Seattle 2025 Nominations Close


          Refactor reporting base classes into a common module

d983af3

Issue: #199
Milestone: Seattle 2025 Nominations Close


          ui: improve ordering in the nomination admin list

c045a53

Issue: #199
Milestone: Seattle 2025 Nominations Close


          bugfix: don't create one user per row

1c4affd

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone added 6 commits

February 13, 2025 00:33


          nit: delete the unused group_works template

e497fe3

Issue: #199
Milestone: Seattle 2025 Nominations Close


          feat: create a report that renders ballots

a608c5f

This is the report that is needed to provide EPH input

Issue: #199
Milestone: Seattle 2025 Nominations Close


          dev: ignore src/staticfiles

43c0fb3

This gets added to by collectstatic

Issue: #199
Milestone: Seattle 2025 Nominations Close


          When selecting works, try preselect one

a28a8de

- find the most similar work in the works table for the first match
- include enabling the similarity check in postgres by default

Issue: #199
Milestone: Seattle 2025 Nominations Close


          Link new nominations with existing works if they fit

172c35e

Issue: #199
Milestone: Seattle 2025 Nominations Close


          EPH step display

2ad1e2b

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone temporarily deployed to release-pypi

February 13, 2025 08:58

— with

GitHub Actions Inactive

offbyone added 5 commits

February 13, 2025 17:19


          bug: clear up duplicate rows in the reports

ce60445

Issue: #199
Milestone: Seattle 2025 Nominations Close


          ui: Show a bar between fields in the canonicalization view

f6465cd

Issue: #199
Milestone: Seattle 2025 Nominations Close


          bug: EPH HAS SIX OUTPUTS

92d73f7

Not Five.

Not Four.

SIX

Issue: #199
Milestone: Seattle 2025 Nominations Close


          ui: the ballot report should be a table

183b53e

Issue: #199
Milestone: Seattle 2025 Nominations Close


          Only associate nominations automatically when there is an exact match

bd5d78f

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone temporarily deployed to release-pypi

February 14, 2025 03:57

— with

GitHub Actions Inactive

offbyone added 2 commits

February 13, 2025 23:51


          Associate bulk nominations in the background

b20f9a8

This is on a best-effort basis

Issue: #199
Milestone: Seattle 2025 Nominations Close


          ui: show the nominator in the works subtable

ec4a8ac

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone temporarily deployed to release-pypi

February 14, 2025 08:41

— with

GitHub Actions Inactive


          Updated some things in the admin

1d718b1

- improved the sorting of the autocomplete work field
- figure out sorting of the matched work
- add a button to fast-create a single work

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone temporarily deployed to release-pypi

February 16, 2025 03:18

— with

GitHub Actions Inactive

offbyone added 4 commits

February 16, 2025 09:54


          ui: move the canonicalized work closer to the proposed title

f97f6ce

Issue: #199
Milestone: Seattle 2025 Nominations Close


          docs: A brief introduction to Canonicalization

eaeb96b

Issue: #199
Milestone: Seattle 2025 Nominations Close


          docs: describe voting and nomination

Issue: #199
Milestone: Seattle 2025 Nominations Close


          dev: don't try to release on tags

fd13455

This causes a conflicting workflow when running real releases that
create tags. It's a pain in the ass

Issue: #199
Milestone: Seattle 2025 Nominations Close

offbyone temporarily deployed to release-pypi

February 16, 2025 18:46

— with

GitHub Actions Inactive

This was referenced Feb 16, 2025

Canonicalization - automatically associate nominations with a work #224

Closed

Canonicalization - works-based report #225

Closed

Nominations - Run EPH on the ballot #226

Closed

offbyone merged commit f52fd31 into main

10 of 13 checks passed

offbyone deleted the canonicalize branch

February 16, 2025 19:09

offbyone mentioned this pull request

Implement Nomination Canonicalization #86

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet