Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glasswalker announce disabled + Blood Hunt announce fixed to vampires. #732

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Nanai
Copy link

@Nanai Nanai commented Feb 10, 2025

About The Pull Request

This should do as asked from the previous, and also, make only vampires see blood hunt announcements.

Why It's Good For The Game

One requested feature, and one simple sanity feature so normal humies can no longer see blood hunts announces. Shhh!

Changelog

🆑
fix: Glasswalkers should no longer invoke CentComm.
fix: CentComm does not exist in the early two thousands anymore, and will instead be the City Council.
qol: Blood Hunts will no longer show to uninvolved splats.
qol: Round end text should be far more lore compliant.
🆑

Nanai added 2 commits February 9, 2025 17:06
…lore friendly and no longer referencing a non-existent space station. (It was driving me nuts.)
… only appear to vampires. Fixes a typo in blood hunt feedback.
@XanderDox
Copy link
Contributor

Oh I see you made a new PR, ignore my last comment on the closed one.

@XanderDox
Copy link
Contributor

Changelog ✨

@XanderDox XanderDox added Fix Rewrites a bug so it appears in different circumstances Oversight We have no quality control labels Feb 10, 2025
@Nanai
Copy link
Author

Nanai commented Feb 10, 2025

Okay, okay. There! All good?

Copy link
Contributor

@XanderDox XanderDox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things to go over and then this looks good to me (but a maintainer will also probably do a final once over)

code/__HELPERS/roundend.dm Outdated Show resolved Hide resolved
code/_onclick/hud/alert.dm Outdated Show resolved Hide resolved
code/modules/events/pirates.dm Show resolved Hide resolved
code/__HELPERS/roundend.dm Outdated Show resolved Hide resolved
code/modules/events/pirates.dm Show resolved Hide resolved
code/modules/vtmb/gamemodes/bloodhunt.dm Outdated Show resolved Hide resolved
code/modules/wod13/special_shit.dm Outdated Show resolved Hide resolved
@Nanai
Copy link
Author

Nanai commented Feb 11, 2025

Alright! All set?

@XanderDox XanderDox requested a review from Miraviel February 11, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Oversight We have no quality control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants