-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glasswalker announce disabled + Blood Hunt announce fixed to vampires. #732
Open
Nanai
wants to merge
10
commits into
WorldOfDarknessXIII:master
Choose a base branch
from
Nanai:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lore friendly and no longer referencing a non-existent space station. (It was driving me nuts.)
… only appear to vampires. Fixes a typo in blood hunt feedback.
Oh I see you made a new PR, ignore my last comment on the closed one. |
Changelog ✨ |
XanderDox
added
Fix
Rewrites a bug so it appears in different circumstances
Oversight
We have no quality control
labels
Feb 10, 2025
Okay, okay. There! All good? |
Miraviel
requested changes
Feb 10, 2025
XanderDox
suggested changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things to go over and then this looks good to me (but a maintainer will also probably do a final once over)
Miraviel
requested changes
Feb 10, 2025
boop! Co-authored-by: Adri <[email protected]>
Co-authored-by: Adri <[email protected]>
Co-authored-by: Adri <[email protected]>
Alright! All set? |
XanderDox
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This should do as asked from the previous, and also, make only vampires see blood hunt announcements.
Why It's Good For The Game
One requested feature, and one simple sanity feature so normal humies can no longer see blood hunts announces. Shhh!
Changelog
🆑
fix: Glasswalkers should no longer invoke CentComm.
fix: CentComm does not exist in the early two thousands anymore, and will instead be the City Council.
qol: Blood Hunts will no longer show to uninvolved splats.
qol: Round end text should be far more lore compliant.
🆑