Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baali can diablerize #728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boy2mantwicethefam
Copy link
Contributor

@boy2mantwicethefam boy2mantwicethefam commented Feb 10, 2025

About The Pull Request

This was done on request, and allows Baali vampires to diablerize people, which is in line with how they consistently do evil things. I held off making this PR until after diablerizing was nerfed so that it is not basically a progress wipe.
This also rearranges the diablerie check so that it is a little bit more ordered and easy to read.

Why It's Good For The Game

Makes the Baali more in line with their splats and encourages them.
Makes the code easier to read at a glance.

Changelog

🆑
balance: Baali can now diablerize other vampires. Because they are evil.
/:cl:

@XanderDox XanderDox added Code Improvement Code is now easier to copy paste. Feature Exposes new bugs in interesting ways labels Feb 10, 2025
@Miraviel
Copy link
Contributor

We had a lengthy discussion on Discord where I warned you that if you do not fill out PR templates, we will no longer review your PRs.

@Miraviel Miraviel closed this Feb 10, 2025
@Miraviel Miraviel reopened this Feb 10, 2025
@XanderDox XanderDox added Frozen Wait for someone else's PR to be merged Feature Freeze Wait in line behind this PR and removed Frozen Wait for someone else's PR to be merged labels Feb 12, 2025
@XanderDox
Copy link
Contributor

Hello! Your PR has been marked as Feature Freeze as it relates to Species/Splat code.

A Maintainer may decide to exempt your PR. Until then, you are encouraged to direct your PR to the ongoing species refactor branch.

@XanderDox XanderDox added Frozen Wait for someone else's PR to be merged and removed Feature Freeze Wait in line behind this PR labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Code is now easier to copy paste. Feature Exposes new bugs in interesting ways Frozen Wait for someone else's PR to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants