Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a typing indicator to the me command, small say refactor, crinos speech bubble #725

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Miraviel
Copy link
Contributor

@Miraviel Miraviel commented Feb 9, 2025

About The Pull Request

Updated our say command a little, here are the changes:

  • Added the speech bubble to the me and whisper commands
  • Added a line ending (...), (!) or (?) bubble that lingers for 2 seconds after you sent a verbal message, depending on the last character of the message
  • Refactored how the typing indicator works
  • Added a limitation of 512 characters to the say, me, and whisper commands
  • Added a custom bubble for the Crinos form, if the Garou players like this, we can have one for the Glabro and Lupus forms as well (we just need sprites, it's a one-line code change)
  • Removed the input_say() verb, it was pointless

NPCs currently do not use this system.

dreamseeker_KLjVAV7kKR

Why It's Good For The Game

We are supposedly a roleplay server, so small features like this help with immersion. Now you can see if someone is writing a lengthy emote.

This can be later expanded to atom_say() that I also intend to port over.

The only concern I have that I might have missed a case where the bubble lingers, but that might be a trial & error thing to find.

Changelog

  • Added the speech bubble to the me and whisper commands.
  • Added a line ending (...), (!) or (?) bubble that lingers for 2 seconds after you sent a verbal message, depending on the last character of the message.
  • Added a limitation of 512 characters to the say, me, and whisper commands
  • Added a custom speech bubble for the Crinos form.

@Miraviel Miraviel marked this pull request as draft February 9, 2025 15:11
@Miraviel Miraviel marked this pull request as ready for review February 9, 2025 15:39
@XanderDox XanderDox added Quality of Life Increasing esword damage is not a quality of life for traitors Refactor Makes the code harder to read labels Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Increasing esword damage is not a quality of life for traitors Refactor Makes the code harder to read
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants