Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the malkavianing #722

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

buffyuwu
Copy link

@buffyuwu buffyuwu commented Feb 9, 2025

About The Pull Request

Makes Malkavians text resemble the Bloodlines Malkavian speech font, and adds hallucination texts loosely gathered from the game as well via the gamespot forums

Also, disables radio hallucinations from happening by setting the is_radio var to false. I didn't remove the rest of the radio hallucination code in-case someone feels like going through and updating it to display messages in the correct styling.

This PR utilizes the existing comic sans font as well as some specific unicode replacement characters on certain letters to achieve something resembling the RPG's font.
image
image

Toggleable via a new 'Malkavian' verb tab received when a Malkavian spawns

image

Some new hallucinations (on live currently these three messages would either be HELP! or The prince is a traitor!)

image

Why It's Good For The Game

Malkavians are currently hard to distinguish from non-Malkavians because they suffer no real penalty to choosing to be the insane clan aside from the occasional harmless hallucination. In Bloodlines, you're a raving lunatic with a variety of hallucinations that directly impact your ability to both be understood and to understand the world around you. This PR brings us closer to that, where Malkavians' dialogue now seems as unhinged as their characters should come across.

The font styling starts disabled, and can be turned on in a new 'Malkavian' verb tab after the Malkavian spawns. Good for if your Malkavian is good at masking it.

Changelog

🆑
code: Malkavian text in chat is now Malkavianesque
add: Added much more hallucination text
qol: Removed nonsensical placeholder hallucination text
/:cl:

@theselfish
Copy link
Contributor

I like it, but not all Malkavians are in the schizo-affective vein. This would also ruin any attempts at a Malkavian who isn't obvious.

@boy2mantwicethefam
Copy link
Contributor

It's amazing though I do have some suggestions. I do recommend making it a toggleable ability, perhaps an action granted by the tongue that allows toggling a variable on the tongue that will check whether it will do regular speech or malkavian speech?

@buffyuwu
Copy link
Author

buffyuwu commented Feb 9, 2025

processing changes based on feedback

@crababot
Copy link

crababot commented Feb 9, 2025

It does look really neat but I think overall I'd prefer if it was something that randomly happened (maybe triggers on messages sent through the madness network) rather than a 100% all the time thing

@buffyuwu
Copy link
Author

buffyuwu commented Feb 9, 2025

It does look really neat but I think overall I'd prefer if it was something that randomly happened (maybe triggers on messages sent through the madness network) rather than a 100% all the time thing

making it toggleable, which will roundstart disabled

@XanderDox XanderDox added Feature Exposes new bugs in interesting ways Vampire Does not respect the Traditions Quality of Life Increasing esword damage is not a quality of life for traitors labels Feb 9, 2025
@wgtjunior743
Copy link
Contributor

Very nice, once the discipline freeze is done,the radio will be back with this PR : #504, it will introduce the radio chat into the malk hivemind with other change to that as well.

Copy link
Contributor

@Miraviel Miraviel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny feature, but the code is a mess. You declared a proc, and then used verb syntax for it.

You don't need the item either, people will just find a way to cut it out and replant it into something else. I think you can make it into an action and assign it to malkavians upon spawning in, you should be able to do it when they receive their hivemind (though I'm not sure if they already have a client by then)

@wgtjunior743
Copy link
Contributor

wgtjunior743 commented Feb 10, 2025

Funny feature, but the code is a mess. You declared a proc, and then used verb syntax for it.

You don't need the item either, people will just find a way to cut it out and replant it into something else. I think you can make it into an action and assign it to malkavians upon spawning in, you should be able to do it when they receive their hivemind (though I'm not sure if they already have a client by then)

they do got a client, if there is a H(mob/living/carbon/human), there is a client inside of it, if they are a player.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways Quality of Life Increasing esword damage is not a quality of life for traitors Vampire Does not respect the Traditions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants