Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-Racisms a lot of the NPCs 2 #716

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

theselfish
Copy link
Contributor

About The Pull Request

What are Russians on? Is it something in the water? Why do humans mutate to do this shit?

Why It's Good For The Game

https://www.youtube.com/watch?v=6zkL91LzCMc

Changelog

🆑
fix: Now not everyone is white! Just like we drew up.
/:cl:

code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
code/modules/wod13/npcroles.dm Outdated Show resolved Hide resolved
@hex37
Copy link
Contributor

hex37 commented Feb 8, 2025

My personal recommendation is to remove the skin tone lists entirely, and have the code just pick any allowed color at random. I did something like it in this PR:

#443

That way, when more roles are made in the future nobody has to go through the trouble of defining which skin color they are allowed to be

@theselfish
Copy link
Contributor Author

My personal recommendation is to remove the skin tone lists entirely, and have the code just pick any allowed color at random. I did something like it in this PR:

#443

That way, when more roles are made in the future nobody has to go through the trouble of defining which skin color they are allowed to be

I think there are SOME cases where NPCs should have a skintone list. For example I left out cops and bankers since them being white fits with the theming of VTM's universe.

@XanderDox XanderDox added Fix Rewrites a bug so it appears in different circumstances Oversight We have no quality control labels Feb 9, 2025
@XanderDox XanderDox requested a review from Miraviel February 9, 2025 20:36
@Miraviel Miraviel merged commit 842d3f2 into WorldOfDarknessXIII:master Feb 13, 2025
4 checks passed
@theselfish theselfish deleted the whatthefuck branch February 13, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Oversight We have no quality control
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants