Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher radio follow up #709

Merged
merged 39 commits into from
Feb 13, 2025
Merged

Conversation

Decepteor
Copy link
Contributor

@Decepteor Decepteor commented Feb 7, 2025

About The Pull Request

Just a quick follow-on PR for the new dispatcher job. I've made it so the dispatcher radios the police now, rather than them hearing the call.

Also fixed the NPC witness system spamming radio chatter for every radio.

image
image

Why It's Good For The Game

Less radio spam!

Changelog

🆑

fix: fixed the dispatch radio chatter

/:cl:

Decepteor and others added 30 commits December 30, 2024 19:09
…s/clinic staff's personal phones. Renovated the building attached to the police station to be the dispatch office.
@K4rlox

This comment was marked as off-topic.

@Decepteor
Copy link
Contributor Author

@K4rlox 911 calling the radio is all I've removed!

@Metekillot Metekillot self-assigned this Feb 8, 2025
@Metekillot
Copy link
Contributor

Metekillot commented Feb 8, 2025

So the spirit of this is fine but crime reporting is pretty broken so this seems to actually stop murders from being reported.

https://github.com/decepteor/world-of-darkness-13/blob/0a9106b52b6618d902619830c21c0350c72f52c8/code/modules/wod13/onyxcombat.dm#L24

Make a similar change here and it should be fine.

Copy link
Contributor

@Metekillot Metekillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Decepteor Decepteor requested a review from Metekillot February 8, 2025 13:44
@Decepteor
Copy link
Contributor Author

Screenshots included to prove it's all working

@XanderDox
Copy link
Contributor

Can we have a way to contact the clinic too? They also hate hearing the chatter.

@Decepteor
Copy link
Contributor Author

I'll maybe make a link for the clinic in a future PR!

@XanderDox XanderDox added Fix Rewrites a bug so it appears in different circumstances Oversight We have no quality control Quality of Life Increasing esword damage is not a quality of life for traitors labels Feb 9, 2025
@Decepteor
Copy link
Contributor Author

This PR is ready!

@Miraviel Miraviel merged commit 7522d5f into WorldOfDarknessXIII:master Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances Oversight We have no quality control Quality of Life Increasing esword damage is not a quality of life for traitors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants