QOL, Card is usuable direclty in most shops.

[wgtjunior743]

About The Pull Request

I had this idea for a while just took a while to start, basically you can insert your card into any shop besides the illegal products, asking for your pin and then it will have your bank money , that you can use to buy the items in the shop, the shop will store the card while you use it, you can alt click to withdraw it.

I am not sure on the idea that you can't use cards to buy illegal stuff in the sense of how easy is to a illegal business to fake what they are selling in the USA and ppl being able to do that with no issues, i know stuff about the silk road but this is much earlier.

Buying stuff:

Black market shops:

Why It's Good For The Game

I always felt like we barely used the card in the game, atleast for me and most of the people is to use the card to withdraw all our money and then use to do whatever, now atleast you got a reason to keep some money in your card so you can easily buy anything non illegal.

Changelog

🆑
fix: Minor message that used points instead of money.
qol: You can know use your card in all the shops besides the illegal ones, BM and laundrymat.
/:cl:

[Miraviel]

Debit cards are underutilised, that is indeed a problem. However, I would not add paying with cards in shops (and later, the warehouse, if we wanted to be consistent), simply because the game is set in 2005. Paying with card everywhere was barely a dream back then.

I know sometimes mechanics are more important than the lore/atmosphere, but I think this is one of those things that would take away from it. If cards were used like this, we could just go back to ID cards and slowly start reverting to default ss13 features in the name of comfort.

[wgtjunior743]

Debit cards are underutilised, that is indeed a problem. However, I would not add paying with cards in shops (and later, the warehouse, if we wanted to be consistent), simply because the game is set in 2005. Paying with card everywhere was barely a dream back then.

I know sometimes mechanics are more important than the lore/atmosphere, but I think this is one of those things that would take away from it. If cards were used like this, we could just go back to ID cards and slowly start reverting to default ss13 features in the name of comfort.

i would have to disagree with that, after a couple of searches in the internet about specially debit cards usage in 2000-2006 and then digging up further upon getting some articles from chat gpt such as : https://www.federalreserve.gov/pubs/feds/2006/200616/200616pap.pdf?utm_source=chatgpt.com and https://www.kansascityfed.org/Research/documents/6675/GuideATM_DebitCardIndustry_2016.pdf?utm_source=chatgpt.com , people were shifting from using ATM with their cards to the usage of debit cards directly and in a few years it would what people would always do.

At the moment the debit card is by far not used and could even be called useless, if interacting directly with an atm to withdraw our money and make transactions without a card, people would not even care.
The point is that the usage of cards and debit cards were real back then, they started earlier as 1960s in the USA, San Francisco is not a small city and the game is in the USA both a first world country and a place with innovation , if it was a game situated in a third-world country i would agree with you or a place like Japan or Germany besides being first-worlds have a general heavy usage of money rather than cards to use in shops.

What is the point of having a debit card if you can't use it as a debit card?
Besides it is intentional that you can't use it to buy products from the warehouse, i even thought about making the warehouse own little editable shop for the Dealer(i will still prob do but it will be cash only too), most people will use their hard cash for illegal stuff , warehouse products , deals or paying services while using their card for minor products like food, cloths and misc items.

[wgtjunior743]

Debit cards are underutilised, that is indeed a problem. However, I would not add paying with cards in shops (and later, the warehouse, if we wanted to be consistent), simply because the game is set in 2005. Paying with card everywhere was barely a dream back then.

I know sometimes mechanics are more important than the lore/atmosphere, but I think this is one of those things that would take away from it. If cards were used like this, we could just go back to ID cards and slowly start reverting to default ss13 features in the name of comfort.

And please don't request changes on my PRs unless you are improving the code/fixing an issue or you are a maintainer yourself.
There is the suggest changes option and that is what people do.

[Miraviel]

And please don't request changes on my PRs unless you are improving the code/fixing an issue or you are a maintainer yourself. There is the suggest changes option and that is what people do.

Only maintainers and above can do this, I am a maintainer myself. I use request changes as a blocking review, because there is no other option on Github besides Comment (does not block) Approve (approval) and Request Changes.

[wgtjunior743]

And please don't request changes on my PRs unless you are improving the code/fixing an issue or you are a maintainer yourself. There is the suggest changes option and that is what people do.

Only maintainers and above can do this, I am a maintainer myself. I use request changes as a blocking review, because there is no other option on Github besides Comment (does not block) Approve (approval) and Request Changes.

an example of a suggested changes :

The github site lacks some features, that type of suggestion needs to be in spaces like vscode

[Miraviel]

an example of a suggested changes :

The github site lacks some features, that type of suggestion needs to be in spaces like vscode

I am aware of this - but I have no code suggestion to make in this situation, as I would prefer if cards just did not work in shops, in general, to facilitate the usage of cash more, which is the entire PR. Again, this is my own, individual opinion, so if the other maintainers take the other position, I'll swap it to approved and let them merge it.