Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reroll the roll code #677

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Conversation

hex37
Copy link
Contributor

@hex37 hex37 commented Feb 4, 2025

About The Pull Request

Improves the storyteller roll to have better big O complexity

Checks if people passed through roll_viewer are actually in possession of a client

Makes the preference option for toggling rolls exist; was deleted in a bad merge

Why It's Good For The Game

uh, roll good, add rolls to all things pls, thx

Changelog

🆑
add: Readded the preferences toggle for storyteller rolls
qol: optimized the storyteller's roll code
fix: Fixed runtimes occurring when rolling against an NPC
/:cl:

@Miraviel
Copy link
Contributor

Miraviel commented Feb 8, 2025

Do you have a process to test it? I set the preference to All Rolls, tried to invoke it in a few ways, it never showed up. How did you test your code?

@hex37
Copy link
Contributor Author

hex37 commented Feb 8, 2025

@Miraviel You can test it by slapping people with your fist, It reveals that punch code is bugged and almost always knocks people over, which is cool

@XanderDox XanderDox added Code Improvement Code is now easier to copy paste. Fix Rewrites a bug so it appears in different circumstances labels Feb 9, 2025
@XanderDox
Copy link
Contributor

Please add a proper changelog for the updates channel.

@hex37
Copy link
Contributor Author

hex37 commented Feb 9, 2025

@XanderDox
Did I do it right?

@XanderDox
Copy link
Contributor

@XanderDox Did I do it right?

You did amazing boo.

@hex37
Copy link
Contributor Author

hex37 commented Feb 9, 2025

Thanks also MERGE ME PLS N THANKS

@Miraviel Miraviel merged commit 8308809 into WorldOfDarknessXIII:master Feb 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Code is now easier to copy paste. Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants