-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reroll the roll code #677
reroll the roll code #677
Conversation
Do you have a process to test it? I set the preference to All Rolls, tried to invoke it in a few ways, it never showed up. How did you test your code? |
@Miraviel You can test it by slapping people with your fist, It reveals that punch code is bugged and almost always knocks people over, which is cool |
Please add a proper changelog for the updates channel. |
@XanderDox |
You did amazing boo. |
Thanks also MERGE ME PLS N THANKS |
About The Pull Request
Improves the storyteller roll to have better big O complexity
Checks if people passed through roll_viewer are actually in possession of a client
Makes the preference option for toggling rolls exist; was deleted in a bad merge
Why It's Good For The Game
uh, roll good, add rolls to all things pls, thx
Changelog
🆑
add: Readded the preferences toggle for storyteller rolls
qol: optimized the storyteller's roll code
fix: Fixed runtimes occurring when rolling against an NPC
/:cl: