Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix statistical data merging logic #42

Merged
merged 5 commits into from
Jan 27, 2025
Merged

fix statistical data merging logic #42

merged 5 commits into from
Jan 27, 2025

Conversation

eiennohito
Copy link
Collaborator

@eiennohito eiennohito commented Jan 24, 2025

This PR makes statistical data merge logic correctly merge transitive and partially intersecting sets.

See tests.

Notation: pre-merged sets are in brackets, individual elements are noted with letters.

Now situations like:

  • (A, B, C), (B, C, D), (D, E, F) -> (A, B, C, D, E , F)
  • (A, G, H), (B, F, H), (C, H, X) -> (A, B, C, G, H, X)
    are handled correctly.

Also fixes the --no-ones flag which had its meaning inversed :|

Also bumps spark/scala versions.

@mh-northlander you may want to see this

@eiennohito eiennohito merged commit 23dc7b2 into main Jan 27, 2025
2 checks passed
@eiennohito eiennohito deleted the fix/merge branch January 27, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant