Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python binding #41

Merged
merged 8 commits into from
Sep 30, 2021
Merged

Python binding #41

merged 8 commits into from
Sep 30, 2021

Conversation

mh-northlander
Copy link
Collaborator

@mh-northlander mh-northlander commented Sep 27, 2021 •
edited by eiennohito
Loading

See #25

eiennohito
eiennohito reviewed Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@eiennohito eiennohito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
We will deal with migration to StatefulAnalyzer later (when it will be implemented).

python/src/lib.rs Outdated Show resolved Hide resolved
sudachi/src/plugin/connect_cost.rs Outdated Show resolved Hide resolved
@mh-northlander mh-northlander mentioned this pull request Sep 28, 2021
Merged
@mh-northlander mh-northlander marked this pull request as ready for review September 29, 2021 08:33
@mh-northlander mh-northlander changed the title WIP Python binding Python binding Sep 29, 2021
eiennohito
eiennohito reviewed Sep 29, 2021
View reviewed changes
Copy link
Collaborator

@eiennohito eiennohito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please rebase on the develop branch

python/README.md Show resolved Hide resolved
python/src/tokenizer.rs Show resolved Hide resolved
eiennohito
eiennohito approved these changes Sep 30, 2021
View reviewed changes
Copy link
Collaborator

@eiennohito eiennohito left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, rebase & merge (this should be squashed)

@mh-northlander mh-northlander merged commit 3450c0a into WorksApplications:develop Sep 30, 2021
@mh-northlander mh-northlander deleted the python-binding branch September 30, 2021 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eiennohito eiennohito eiennohito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mh-northlander @eiennohito