Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow empty morpheme by default #151

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

mh-northlander
Copy link
Collaborator

@mh-northlander mh-northlander commented Nov 6, 2024

NOTE: This PR depends on #149 and should be merged after that.
Diff: fix/148-correct-offset...fix/disallow-empty-morpheme

  • Set allowEmptyMorpheme sudachi setting to false by default.
    • This makes all tokens have non-empty span in the input text and will make highlighting work correctly.
  • Add new allow_empty_morpheme parameter.

@mh-northlander mh-northlander changed the title WIP: Disallow empty morpheme by default Disallow empty morpheme by default Nov 6, 2024
@mh-northlander mh-northlander changed the base branch from fix/148-correct-offset to develop November 6, 2024 09:14
@mh-northlander mh-northlander reopened this Nov 6, 2024
Copy link

sonarqubecloud bot commented Nov 6, 2024

@mh-northlander mh-northlander merged commit 03224f6 into develop Nov 11, 2024
31 checks passed
@mh-northlander mh-northlander deleted the fix/disallow-empty-morpheme branch November 11, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants