Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Fix: Rebuild Event RSVP Pattern. #624

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix: Rebuild Event RSVP Pattern. #624

merged 1 commit into from
Oct 24, 2024

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 23, 2024

Description

Fixes #618

Rebuilding the pattern with the code that @beafialho shared. I updated the "Free workshop" section to fix the alignment. We can't update the text for the date as we already passed the string freeze.

Screenshots

Screen.Recording.2024-10-23.at.13.38.20.mov

Testing Instructions

  1. Create a page.
  2. Add the pattern.
  3. Test that the pattern is looking like the designs, and works well in different viewports.

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Oct 23, 2024
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@beafialho
Copy link
Contributor

Thank you @juanfra! It's looking good to me.

We can't update the text for the date as we already passed the string freeze.

Yes, this is fine 👍

@juanfra
Copy link
Member Author

juanfra commented Oct 24, 2024

Thanks Bea!

@carolinan I'm merging this one. Please let me know if you find anything that you would change in the code.

@juanfra juanfra merged commit c034cbf into trunk Oct 24, 2024
4 checks passed
@juanfra juanfra deleted the update/event-rsvp branch October 24, 2024 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebuild Event RSVP Pattern not using Grid
2 participants