Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

HeatherActon
Copy link

@HeatherActon HeatherActon commented Oct 22, 2024

Description
Closes #621

The default page template and the page no title template did not display comments by default and with this fix, they should display as seen below.

Screenshots
Screenshot 2024-10-22 at 11 45 57 AM
Screenshot 2024-10-22 at 11 48 42 AM

Testing

  1. Install theme unit test data.
  2. Visit the "Page with comments" page - comments should be visible along with the form.
  3. Change the template for this page to "Page no title".
  4. Visit the "Page with comments" again - comments and form should be visible and nicely aligned at all screen sizes.

when the comments pattern was added, it was not contained with the post content. reapplied the page.html markup with smaller top margin.
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: HeatherActon <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@HeatherActon
Copy link
Author

Closing request, per conversation here: #621

twentytwentyfive is not shipping with comments on by default. Block can be added by user if they desire.

Opened new issue in theme test data about confusing content on "Page with comments" WordPress/theme-test-data#90

@HeatherActon HeatherActon deleted the fix/621-page-with-comments-does-not-display-comments branch October 22, 2024 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page with comments does not display comments
1 participant