Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Sunrise & preset 6: Remove font size from author name #614

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 22, 2024

Description

This PR removes the default font size from the post author name in the Sunrise theme style variation and typography preset 6.
Closes #613

Testing Instructions
View the author name below the featured image in the default single post template.
All the text "Written by name in category" should have the same font size.

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan added the [Type] Enhancement A suggestion for improvement. label Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It's working well.

Screen.Recording.2024-10-22.at.12.49.04.mov

@juanfra juanfra merged commit 34b98a2 into trunk Oct 22, 2024
6 checks passed
@juanfra juanfra deleted the update/sunrise-author-name branch October 22, 2024 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sunrise: Remove Author Name font size preset
2 participants