Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try: Clean up posts patterns #532

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

juanfra
Copy link
Member

@juanfra juanfra commented Oct 9, 2024

Description

Try for #411

  • Remove "Business homepage" from that list.
  • Remove "Shop homepage" from that list.
  • Improve the way the "Photo blog posts" is displayed there. It is a query loop block without side spacing, that's why there no gap to the sides.

Screenshots

Screen.Recording.2024-10-09.at.12.00.02.mov

Testing Instructions

  1. Create a page.
  2. Open the inserter
  3. Go to patterns
  4. Go to "Posts"
  5. Confirm that the homepages are not there and that the "Photo blog posts" shows three columns.

@juanfra juanfra added the [Type] Bug An existing feature does not function as intended. label Oct 9, 2024
@juanfra juanfra requested a review from carolinan October 9, 2024 10:04
@juanfra juanfra self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link

github-actions bot commented Oct 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: juanfra <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
I do not see a visible difference on the photo blog posts. Perhaps because I am using the small laptop screen today.
Adding the viewport width makes it more consistent with the other patterns.

@juanfra
Copy link
Member Author

juanfra commented Oct 9, 2024

Thanks!

I do not see a visible difference on the photo blog posts. Perhaps because I am using the small laptop screen today.
Adding the viewport width makes it more consistent with the other patterns.

Without the viewport width it was showing the preview in two columns to me. I recorded a screencast of how it looked here.

@juanfra juanfra merged commit 8ba818f into trunk Oct 9, 2024
6 checks passed
@juanfra juanfra mentioned this pull request Oct 9, 2024
@juanfra juanfra deleted the update/clean-up-posts-patterns branch October 9, 2024 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants