Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try/type rebased #445

Merged
merged 26 commits into from
Sep 27, 2024
Merged

Try/type rebased #445

merged 26 commits into from
Sep 27, 2024

Conversation

jasmussen
Copy link
Contributor

Description

A rebased version of #422. Pushed as a separate branch in case I made an error in the rebase.

Copy link

github-actions bot commented Sep 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: richtabor <[email protected]>
Co-authored-by: jasmussen <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Sep 27, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@jasmussen jasmussen mentioned this pull request Sep 27, 2024
theme.json Outdated Show resolved Hide resolved
@carolinan
Copy link
Contributor

@richtabor @jasmussen In the twentytwentyfive/hero-podcast pattern, a heading was changed from an H1 to H2.
The reason it was set to an H1 was because it is the first heading on one of the landing pages, twentytwentyfive/page-landing-podcast.
This landing page must have an H1, be it this one or another, because it is intended to be used with "page not title" template.

@carolinan carolinan merged commit cd9d73c into trunk Sep 27, 2024
4 checks passed
@richtabor
Copy link
Member

richtabor commented Sep 30, 2024

@richtabor @jasmussen In the twentytwentyfive/hero-podcast pattern, a heading was changed from an H1 to H2.
The reason it was set to an H1 was because it is the first heading on one of the landing pages, twentytwentyfive/page-landing-podcast.
This landing page must have an H1, be it this one or another, because it is intended to be used with "page not title" template.

It's far more likely this will be used on existing pages, thus adding an H1 in the middle of the page.

We cannot accurately assume the template that will be employed with this particular pattern. If anything, we assume the default page template is utilized and this pattern is leveraged individually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants