Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site Health test for Cache-Control: no-store page response header which disables bfcache #1807

Merged
merged 18 commits into from
Jan 24, 2025

Further clarify that the bfcache is for unauthenticated requests

fe7444b
Select commit
Loading
Failed to load commit list.
Merged

Add Site Health test for Cache-Control: no-store page response header which disables bfcache #1807

Further clarify that the bfcache is for unauthenticated requests
fe7444b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2025 in 0s

65.82% (+0.35%) compared to b7c4475

View this Pull Request on Codecov

65.82% (+0.35%) compared to b7c4475

Details

Codecov Report

Attention: Patch coverage is 96.20253% with 3 lines in your changes missing coverage. Please review.

Project coverage is 65.82%. Comparing base (b7c4475) to head (fe7444b).

Files with missing lines Patch % Lines
...gins/performance-lab/includes/site-health/load.php 0.00% 2 Missing ⚠️
...ite-health/bfcache-compatibility-headers/hooks.php 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1807      +/-   ##
==========================================
+ Coverage   65.47%   65.82%   +0.35%     
==========================================
  Files          85       87       +2     
  Lines        6748     6827      +79     
==========================================
+ Hits         4418     4494      +76     
- Misses       2330     2333       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.