Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Site Health test to verify that static assets are served with far-future expires #1727

Merged
merged 34 commits into from
Jan 22, 2025
Merged
Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
dc9e364
Add site health checks for far-future expiration headers
b1ink0 Dec 9, 2024
4cb07aa
Add filter for customizing far-future headers threshold
b1ink0 Dec 9, 2024
ec9a552
Refactor far-future headers checks and improve asset validation logic
b1ink0 Dec 9, 2024
dd8e70d
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Dec 9, 2024
0078cfc
Use assets from wp-includes for far-future headers site health check
b1ink0 Dec 10, 2024
3e5d958
Add filter to customize assets checked for far-future headers
b1ink0 Dec 10, 2024
35e7977
Enhance far-future headers check to return detailed results and gener…
b1ink0 Dec 10, 2024
3db5886
Improve far-future headers checks by adding detailed failure reasons …
b1ink0 Dec 10, 2024
655d4e5
Add test to ensure status is 'good' when all headers are valid
b1ink0 Dec 11, 2024
20099bf
Add test for assets with conditional caching
b1ink0 Dec 12, 2024
54f3621
Add test for status messages based on far-future headers results
b1ink0 Dec 12, 2024
0a776c5
Add tests for filters affecting far-future headers asset checks
b1ink0 Dec 12, 2024
3c98337
Refactor to use filenames instead of extenstions in failure details
b1ink0 Dec 12, 2024
7afd746
Filter assets to ensure only string URLs are checked
b1ink0 Jan 8, 2025
3fcd641
Update parameter type hints for far-future headers functions
b1ink0 Jan 8, 2025
54c73ec
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Jan 8, 2025
6a2da47
Include max-age, expires actual value and threshold value in error me…
b1ink0 Jan 9, 2025
48166ac
Simplify filename extraction and conditional logic
b1ink0 Jan 9, 2025
17d380e
Refactor header checks to use null coalescing and improve conditionals
b1ink0 Jan 9, 2025
200b518
Fix far future headers tests failing due to updated error messages
b1ink0 Jan 9, 2025
1b4cef4
Improve error messages for far future headers check
b1ink0 Jan 10, 2025
ed28196
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Jan 10, 2025
ee3a57d
Update labels to make them less technical
b1ink0 Jan 15, 2025
f6ba392
Add cover annotations for tests and test for when no assets are passed
b1ink0 Jan 15, 2025
0620840
Mark functions as private
b1ink0 Jan 15, 2025
7ebdc87
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Jan 16, 2025
49ca83f
Add covers tags
westonruter Jan 17, 2025
12d0b71
Refactor to only return array to improve clarity, Simplify conditiona…
b1ink0 Jan 20, 2025
aec6f80
Add additional tests to improve code coverage
b1ink0 Jan 20, 2025
2190d60
Rename directories and files from 'far-furure-headers' to 'effective-…
b1ink0 Jan 22, 2025
4f1a00d
Rename functions and update comments to reflect effective caching hea…
b1ink0 Jan 22, 2025
2d08732
Merge branch 'trunk' into add/far-future-expiration-test
b1ink0 Jan 22, 2025
a048e9f
Update comments to reflect effective asset cache headers in site heal…
b1ink0 Jan 22, 2025
2c70bd0
Update comment
westonruter Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,320 @@
<?php
/**
* Helper function to detect if static assets have far-future expiration headers.
*
* @package performance-lab
* @since n.e.x.t
*/

if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.

Check warning on line 10 in plugins/performance-lab/includes/site-health/far-future-headers/helper.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/helper.php#L9-L10

Added lines #L9 - L10 were not covered by tests
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #1815:

Suggested change
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
// @codeCoverageIgnoreEnd


/**
* Callback for the far-future caching test.
*
* @since n.e.x.t
* @access private
*
* @return array{label: string, status: string, badge: array{label: string, color: string}, description: string, actions: string, test: string} Result.
*/
function perflab_ffh_assets_test(): array {
$result = array(
'label' => __( 'Your site serves static assets with an effective caching strategy', 'performance-lab' ),
'status' => 'good',
'badge' => array(
'label' => __( 'Performance', 'performance-lab' ),
'color' => 'blue',
),
'description' => sprintf(
'<p>%s</p>',
esc_html__(
'Serving static assets with far-future expiration headers improves performance by allowing browsers to cache files for a long time, reducing repeated requests.',
'performance-lab'
)
),
'actions' => '',
'test' => 'is_far_future_headers_enabled',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we maybe use effective_cache_headers for the name / identifier of this entire functionality? I just find this far_future_headers oddly specific, and it sounds strange to me. The purpose for this Site Health is to have "good" caching headers, and I think we should frame the feature as such, rather than the more technical and IMO too specific "far future" terminology.

This applies to all the identifiers using far_future_headers, like this function, the Site Health check itself, the directory name etc. I think we should use effective_cache_headers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use asset somewhere in the name because this should be differentiated from the effective Cache-Control header for page responses so as to not break bfcache (#1807).

So maybe effective_asset_cache_headers?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter That works for me!

);

// List of assets to check.
$assets = array(
includes_url( 'js/wp-embed.min.js' ),
includes_url( 'css/buttons.min.css' ),
includes_url( 'fonts/dashicons.woff2' ),
includes_url( 'images/media/video.png' ),
);
westonruter marked this conversation as resolved.
Show resolved Hide resolved

/**
* Filters the list of assets to check for far-future headers.
*
* @since n.e.x.t
*
* @param string[] $assets List of asset URLs to check.
*/
$assets = apply_filters( 'perflab_ffh_assets_to_check', $assets );
westonruter marked this conversation as resolved.
Show resolved Hide resolved
$assets = array_filter( (array) $assets, 'is_string' );

// Check if far-future headers are enabled for all assets.
$results = perflab_ffh_check_assets( $assets );

if ( 'good' !== $results['final_status'] ) {
$result['status'] = $results['final_status'];
$result['label'] = __( 'Your site does not serve static assets with an effective caching strategy', 'performance-lab' );

if ( count( $results['details'] ) > 0 ) {
$result['actions'] = sprintf(
'<p>%s</p>%s<p>%s</p>',
esc_html__( 'The following file types do not have the recommended far-future headers. Consider adding or adjusting Cache-Control or Expires headers for these asset types.', 'performance-lab' ),
perflab_ffh_get_extensions_table( $results['details'] ),
esc_html__( 'Note: "Conditionally cached" means that the browser can re-validate the resource using ETag or Last-Modified headers. This results in fewer full downloads but still requires the browser to make requests, unlike far-future expiration headers that allow the browser to fully rely on its local cache for a longer duration.', 'performance-lab' )
);
}
$result['actions'] .= sprintf(
'<p>%s</p>',
esc_html__( 'Far-future Cache-Control or Expires headers can be added or adjusted with a small configuration change by your hosting provider.', 'performance-lab' )
);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two different checks which are getting performed one with Cache-Control, Expires and other with Etag, Last-Modified should there be different messages shown based on the checks?

Copy link
Contributor Author

@b1ink0 b1ink0 Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the new 3db5886 commit a table is used to display reason for different failure cases.


return $result;
}

/**
* Checks if far-future expiration headers are enabled for a list of assets.
*
* @since n.e.x.t
* @access private
*
* @param string[] $assets List of asset URLs to check.
* @return array{final_status: string, details: array{filename: string, reason: string}[]} Final status and details.
*/
function perflab_ffh_check_assets( array $assets ): array {
$final_status = 'good';
$fail_details = array(); // Array of arrays with 'filename' and 'reason'.

foreach ( $assets as $asset ) {
$response = wp_remote_get( $asset, array( 'sslverify' => false ) );

// Extract filename from the URL.
$path_info = pathinfo( (string) wp_parse_url( $asset, PHP_URL_PATH ) );
$filename = $path_info['basename'] ?? basename( $asset );

if ( is_wp_error( $response ) ) {
// Can't determine headers if request failed, consider it a fail.
$final_status = 'recommended';
$fail_details[] = array(
'filename' => $filename,
'reason' => __( 'Could not retrieve headers', 'performance-lab' ),
);
continue;

Check warning on line 109 in plugins/performance-lab/includes/site-health/far-future-headers/helper.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/helper.php#L104-L109

Added lines #L104 - L109 were not covered by tests
}

$headers = wp_remote_retrieve_headers( $response );
if ( ! is_object( $headers ) && 0 === count( $headers ) ) {
// No valid headers retrieved.
$final_status = 'recommended';
$fail_details[] = array(
'filename' => $filename,
'reason' => __( 'No valid headers retrieved', 'performance-lab' ),
);
continue;

Check warning on line 120 in plugins/performance-lab/includes/site-health/far-future-headers/helper.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/helper.php#L115-L120

Added lines #L115 - L120 were not covered by tests
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two if statements lack tests, but I don't think they are critical.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in aec6f80


$check = perflab_ffh_check_headers( $headers );
if ( isset( $check['passed'] ) && $check['passed'] ) {
// This asset passed far-future headers test, no action needed.
continue;
}

// If not passed, decide whether to try conditional request.
if ( false === $check ) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditions here seem a bit confusing to me, related to how perflab_ffh_check_headers() returns either an array or false. I think it would be preferable if perflab_ffh_check_headers always returned an array. Maybe it could always return an array key for missing_max_age which is a boolean. And then this could be changed to:

Suggested change
$check = perflab_ffh_check_headers( $headers );
if ( isset( $check['passed'] ) && $check['passed'] ) {
// This asset passed far-future headers test, no action needed.
continue;
}
// If not passed, decide whether to try conditional request.
if ( false === $check ) {
$check = perflab_ffh_check_headers( $headers );
if ( $check['passed'] ) {
// This asset passed far-future headers test, no action needed.
continue;
}
// If not passed, decide whether to try conditional request.
if ( $check['missing_max_age'] ) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 12d0b71

// Only if no far-future headers at all, we try conditional request.
$conditional_pass = perflab_ffh_try_conditional_request( $asset, $headers );
$final_status = 'recommended';
if ( ! $conditional_pass ) {
$fail_details[] = array(
'filename' => $filename,
'reason' => __( 'No far-future headers and no conditional caching', 'performance-lab' ),
);
} else {
$fail_details[] = array(
'filename' => $filename,
'reason' => __( 'No far-future headers but conditionally cached', 'performance-lab' ),
);
}
} else {
// If there's a max-age or expires but below threshold, we skip conditional.
$final_status = 'recommended';
$fail_details[] = array(
'filename' => $filename,
'reason' => $check['reason'],
);
}
}

return array(
'final_status' => $final_status,
'details' => $fail_details,
);
}
westonruter marked this conversation as resolved.
Show resolved Hide resolved

/**
* Checks if far-future expiration headers are enabled.
*
* @since n.e.x.t
* @access private
*
* @param WpOrg\Requests\Utility\CaseInsensitiveDictionary|array<string, string|array<string>> $headers Response headers.
* @return array{passed: bool, reason: string}|false Detailed result. If passed=false, reason explains why it failed and false if no headers found.
*/
function perflab_ffh_check_headers( $headers ) {
/**
* Filters the threshold for far-future headers.
*
* @since n.e.x.t
*
* @param int $threshold Threshold in seconds.
*/
$threshold = apply_filters( 'perflab_far_future_headers_threshold', YEAR_IN_SECONDS );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better as:

Suggested change
$threshold = apply_filters( 'perflab_far_future_headers_threshold', YEAR_IN_SECONDS );
$threshold = apply_filters( 'perflab_effective_cache_headers_expiration_threshold', YEAR_IN_SECONDS );

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per above:

Suggested change
$threshold = apply_filters( 'perflab_far_future_headers_threshold', YEAR_IN_SECONDS );
$threshold = apply_filters( 'perflab_effective_asset_cache_headers_expiration_threshold', YEAR_IN_SECONDS );


$cache_control = $headers['cache-control'] ?? '';
$expires = $headers['expires'] ?? '';

// Check Cache-Control header for max-age.
$max_age = 0;
if ( '' !== $cache_control ) {
// There can be multiple cache-control headers, we only care about max-age.
foreach ( (array) $cache_control as $control ) {
if ( 1 === preg_match( '/max-age\s*=\s*(\d+)/', $control, $matches ) ) {
$max_age = (int) $matches[1];
break;
}
}
}

// If max-age meets or exceeds the threshold, we consider it good.
if ( $max_age >= $threshold ) {
return array(
'passed' => true,
'reason' => '',
);
}

// If max-age is too low or not present, check Expires.
if ( is_string( $expires ) && '' !== $expires ) {
$expires_time = strtotime( $expires );
$remaining_time = is_int( $expires_time ) ? $expires_time - time() : 0;
if ( $remaining_time >= $threshold ) {
// Good - Expires far in the future.
return array(
'passed' => true,
'reason' => '',
);
}

// Expires header exists but not far enough in the future.
if ( $max_age > 0 ) {
return array(
'passed' => false,
'reason' => sprintf(

Check warning on line 219 in plugins/performance-lab/includes/site-health/far-future-headers/helper.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/helper.php#L217-L219

Added lines #L217 - L219 were not covered by tests
/* translators: 1: actual max-age value in seconds, 2: threshold in seconds */
__( 'max-age below threshold (actual: %1$s seconds, threshold: %2$s seconds)', 'performance-lab' ),
number_format_i18n( $max_age ),
number_format_i18n( $threshold )
),
);

Check warning on line 225 in plugins/performance-lab/includes/site-health/far-future-headers/helper.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/helper.php#L221-L225

Added lines #L221 - L225 were not covered by tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a test is missing for the max-age being present but it not being high enough.

}
return array(
'passed' => false,
'reason' => sprintf(
/* translators: 1: actual Expires header value in seconds, 2: threshold in seconds */
__( 'expires below threshold (actual: %1$s seconds, threshold: %2$s seconds)', 'performance-lab' ),
number_format_i18n( $remaining_time ),
number_format_i18n( $threshold )
),
);
}

// No max-age or expires found at all or max-age < threshold and no expires.
if ( 0 === $max_age ) {
return false;
} else {
// max-age was present but below threshold and no expires.
return array(
'passed' => false,
'reason' => sprintf(
/* translators: 1: actual max-age value in seconds, 2: threshold in seconds */
__( 'max-age below threshold (actual: %1$s seconds, threshold: %2$s seconds)', 'performance-lab' ),
number_format_i18n( $max_age ),
number_format_i18n( $threshold )
),
);
}
}

/**
* Attempt a conditional request with ETag/Last-Modified.
*
* @since n.e.x.t
* @access private
*
* @param string $url The asset URL.
* @param WpOrg\Requests\Utility\CaseInsensitiveDictionary|array<string, string|array<string>> $headers The initial response headers.
* @return bool True if a 304 response was received.
*/
function perflab_ffh_try_conditional_request( string $url, $headers ): bool {
$etag = isset( $headers['etag'] ) ? $headers['etag'] : '';
$last_modified = isset( $headers['last-modified'] ) ? $headers['last-modified'] : '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvement.

Suggested change
$etag = isset( $headers['etag'] ) ? $headers['etag'] : '';
$last_modified = isset( $headers['last-modified'] ) ? $headers['last-modified'] : '';
$etag = $headers['etag'] ?? '';
$last_modified = $headers['last-modified'] ?? '';

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 12d0b71


$conditional_headers = array();
if ( '' !== $etag ) {
$conditional_headers['If-None-Match'] = $etag;
}
if ( '' !== $last_modified ) {
$conditional_headers['If-Modified-Since'] = $last_modified;

Check warning on line 274 in plugins/performance-lab/includes/site-health/far-future-headers/helper.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/helper.php#L274

Added line #L274 was not covered by tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like test coverage for this line is warranted.

}

$response = wp_remote_get(
$url,
array(
'sslverify' => false,
'headers' => $conditional_headers,
)
);

if ( is_wp_error( $response ) ) {
return false;

Check warning on line 286 in plugins/performance-lab/includes/site-health/far-future-headers/helper.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/helper.php#L286

Added line #L286 was not covered by tests
westonruter marked this conversation as resolved.
Show resolved Hide resolved
}

$status_code = wp_remote_retrieve_response_code( $response );
return ( 304 === $status_code );
}

/**
* Generate a table listing files that need far-future headers, including reasons.
*
* @since n.e.x.t
* @access private
*
* @param array<array{filename: string, reason: string}> $fail_details Array of arrays with 'filename' and 'reason'.
* @return string HTML formatted table.
*/
function perflab_ffh_get_extensions_table( array $fail_details ): string {
$html_table = sprintf(
'<table class="widefat striped"><thead><tr><th scope="col">%s</th><th scope="col">%s</th></tr></thead><tbody>',
esc_html__( 'File', 'performance-lab' ),
esc_html__( 'Status', 'performance-lab' )
);

foreach ( $fail_details as $detail ) {
$html_table .= sprintf(
'<tr><td>%s</td><td>%s</td></tr>',
esc_html( $detail['filename'] ),
esc_html( $detail['reason'] )
);
}

$html_table .= '</tbody></table>';

return $html_table;
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php
/**
* Hook callbacks used for far-future headers.
*
* @package performance-lab
* @since n.e.x.t
*/

if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.

Check warning on line 10 in plugins/performance-lab/includes/site-health/far-future-headers/hooks.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/hooks.php#L9-L10

Added lines #L9 - L10 were not covered by tests
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per #1815:

Suggested change
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
// @codeCoverageIgnoreStart
if ( ! defined( 'ABSPATH' ) ) {
exit; // Exit if accessed directly.
}
// @codeCoverageIgnoreEnd


/**
* Adds tests to site health.
*
* @since n.e.x.t
* @access private
*
* @param array{direct: array<string, array{label: string, test: string}>} $tests Site Health Tests.
* @return array{direct: array<string, array{label: string, test: string}>} Amended tests.
*/
function perflab_ffh_add_test( array $tests ): array {
$tests['direct']['far_future_headers'] = array(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above:

Suggested change
$tests['direct']['far_future_headers'] = array(
$tests['direct']['effective_cache_headers'] = array(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per above:

Suggested change
$tests['direct']['far_future_headers'] = array(
$tests['direct']['effective_asset_cache_headers'] = array(

'label' => __( 'Effective Caching Headers', 'performance-lab' ),
'test' => 'perflab_ffh_assets_test',
);
return $tests;

Check warning on line 27 in plugins/performance-lab/includes/site-health/far-future-headers/hooks.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/hooks.php#L23-L27

Added lines #L23 - L27 were not covered by tests
}
add_filter( 'site_status_tests', 'perflab_ffh_add_test' );

Check warning on line 29 in plugins/performance-lab/includes/site-health/far-future-headers/hooks.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/far-future-headers/hooks.php#L29

Added line #L29 was not covered by tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A trivial function to add a test for, but it would ensure test coverage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in aec6f80

4 changes: 4 additions & 0 deletions plugins/performance-lab/includes/site-health/load.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,7 @@
// AVIF headers site health check.
require_once __DIR__ . '/avif-headers/helper.php';
require_once __DIR__ . '/avif-headers/hooks.php';

// Far-Future Headers site health check.
require_once __DIR__ . '/far-future-headers/helper.php';
require_once __DIR__ . '/far-future-headers/hooks.php';

Check warning on line 35 in plugins/performance-lab/includes/site-health/load.php

View check run for this annotation

Codecov / codecov/patch

plugins/performance-lab/includes/site-health/load.php#L34-L35

Added lines #L34 - L35 were not covered by tests
Loading
Loading