Global Styles: Make Additional CSS button always work #68956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR makes the Additional CSS button in the global styles work in all states.
Why?
The global styles sidebar screen switches automatically depending on the state of the canvas view, mainly through the
useEffecthook here. Furthermore, the initial value of the canvas view isundefined.The first time you click the Additional CSS button, the canvas view changes from
undefinedtoglobal-styles-css. TheuseEffect()hook detects this change and navigates the global styles sidebar screens to CSS.After that, you press the back button and then click the Additional CSS button again. This time, the canvas view remains
global-styles-css, souseEffect()hook has no effect and the screen does not switch.How?
In the button's click event, I restored the deleted
goTo()function. This ensures that the Additional CSS button always works, regardless of the state of the canvas view.Furthermore, I removed the similar code in the
useEffect()hook to preventgoTo()from being executed twice.Testing Instructions
Screenshots or screencast
03535722f05de68d15a5d488e829c115.mp4