Skip to content

Commit

Permalink
NumberControl: Fix invalid HTML attributes for infinite bounds (#69033)
Browse files Browse the repository at this point in the history
Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: mirka <[email protected]>
Co-authored-by: afercia <[email protected]>
  • Loading branch information
6 people authored Feb 13, 2025
1 parent 322899e commit ad5c6c1
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Internal

- `NumberControl`: Fix invalid HTML attributes for infinite bounds ([#69033](https://github.com/WordPress/gutenberg/pull/69033)).

## 29.4.0 (2025-02-12)

- `FontSizePicker`: Remove Custom option from dropdown to prevent unexpected context changes during keyboard navigation ([#69038](https://github.com/WordPress/gutenberg/pull/69038)).
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/number-control/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ function UnforwardedNumberControl(
hideHTMLArrows={ spinControls !== 'native' }
isDragEnabled={ isDragEnabled }
label={ label }
max={ max }
min={ min }
max={ max === Infinity ? undefined : max }
min={ min === -Infinity ? undefined : min }
ref={ mergedRef }
required={ required }
step={ step }
Expand Down

1 comment on commit ad5c6c1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in ad5c6c1.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13302448266
📝 Reported issues:

Please sign in to comment.