[ON HOLD] Move date function group from RestrictedPHPFunctions to TimezoneChange

WordPress-Core/ruleset.xml

@@ -519,4 +519,8 @@
 	<!-- Check for correct spelling of WordPress. -->
 	<rule ref="WordPress.WP.CapitalPDangit"/>
 
+	<!-- Use gmdate() not date().
+		 See: https://github.com/WordPress/WordPress-Coding-Standards/issues/1713 -->
+	<rule ref="WordPress.WP.TimezoneChange.date_date"/>
+
 </ruleset>

WordPress-Extra/ruleset.xml

@@ -145,7 +145,9 @@
 	<rule ref="WordPress.Security.PluginMenuSlug"/>
 	<rule ref="WordPress.WP.CronInterval"/>
 	<rule ref="WordPress.WP.PostsPerPage"/>
-	<rule ref="WordPress.WP.TimezoneChange"/>
+	<rule ref="WordPress.WP.TimezoneChange">
+		<severity>5</severity>
+	</rule>
 
 	<!-- Verify some regex best practices.
 		 https://github.com/WordPress/WordPress-Coding-Standards/issues/1371 -->

WordPress/Sniffs/PHP/RestrictedPHPFunctionsSniff.php

@@ -17,7 +17,6 @@
  * @package WPCS\WordPressCodingStandards
  *
  * @since   0.14.0
- * @since   2.2.0  New group `date` added.
  */
 class RestrictedPHPFunctionsSniff extends AbstractFunctionRestrictionsSniff {
 
@@ -43,13 +42,6 @@ public function getGroups() {
 					'create_function',
 				),
 			),
-			'date' => array(
-				'type'      => 'error',
-				'message'   => '%s() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.',
-				'functions' => array(
-					'date',
-				),
-			),
 		);
 	}
 

WordPress/Sniffs/WP/TimezoneChangeSniff.php

@@ -12,9 +12,8 @@
 use WordPressCS\WordPress\AbstractFunctionRestrictionsSniff;
 
 /**
- * Disallow the changing of timezone.
- *
- * @link    https://vip.wordpress.com/documentation/vip-go/code-review-blockers-warnings-notices/#manipulating-the-timezone-server-side
+ * Disallow changing the timezone and use of selective date/time functions which lead to
+ * timezone related bugs.
  *
  * @package WPCS\WordPressCodingStandards
  *
@@ -23,6 +22,7 @@
  *                 class instead of the upstream `Generic.PHP.ForbiddenFunctions` sniff.
  * @since   0.13.0 Class name changed: this class is now namespaced.
  * @since   1.0.0  This sniff has been moved from the `VIP` category to the `WP` category.
+ * @since   2.2.0  New group `date` added.
  */
 class TimezoneChangeSniff extends AbstractFunctionRestrictionsSniff {
 
@@ -41,13 +41,33 @@ class TimezoneChangeSniff extends AbstractFunctionRestrictionsSniff {
 	 */
 	public function getGroups() {
 		return array(
+
+			/*
+			 * Don't change the PHP time zone.
+			 *
+			 * @link https://vip.wordpress.com/documentation/vip-go/code-review-blockers-warnings-notices/#manipulating-the-timezone-server-side
+			 */
 			'timezone_change' => array(
 				'type'      => 'error',
 				'message'   => 'Using %s() and similar isn\'t allowed, instead use WP internal timezone support.',
 				'functions' => array(
 					'date_default_timezone_set',
 				),
 			),
+
+			/*
+			 * Use gmdate(), not date().
+			 *
+			 * @link https://core.trac.wordpress.org/ticket/46438
+			 * @link https://github.com/WordPress/WordPress-Coding-Standards/issues/1713
+			 */
+			'date' => array(
+				'type'      => 'error',
+				'message'   => '%s() is affected by runtime timezone changes which can cause date/time to be incorrectly displayed. Use gmdate() instead.',
+				'functions' => array(
+					'date',
+				),
+			),
 		);
 	}
 

WordPress/Tests/PHP/RestrictedPHPFunctionsUnitTest.inc

@@ -3,6 +3,3 @@
 add_action( 'widgets_init', create_function( '', // Error.
 	'return register_widget( "time_more_on_time_widget" );'
 ) );
-
-$post_data['post_title'] = sprintf( __( 'Draft created on %1$s at %2$s' ), date( __( 'F j, Y' ), $now ), date( __( 'g:i a' ), $now ) ); // Error.
-$post_data['post_title'] = sprintf( __( 'Draft created on %1$s at %2$s' ), gmdate( __( 'F j, Y' ), $now ), gmdate( __( 'g:i a' ), $now ) ); // OK.

WordPress/Tests/PHP/RestrictedPHPFunctionsUnitTest.php

@@ -28,7 +28,6 @@ class RestrictedPHPFunctionsUnitTest extends AbstractSniffUnitTest {
 	public function getErrorList() {
 		return array(
 			3 => 1,
-			7 => 2,
 		);
 	}
 

WordPress/Tests/WP/TimezoneChangeUnitTest.inc

@@ -4,3 +4,6 @@ date_default_timezone_set( 'Foo/Bar' ); // Bad.
 
 $date = new DateTime();
 $date->setTimezone( new DateTimeZone( 'America/Toronto' ) ); // Yay!
+
+$post_data['post_title'] = sprintf( __( 'Draft created on %1$s at %2$s' ), date( __( 'F j, Y' ), $now ), date( __( 'g:i a' ), $now ) ); // Error.
+$post_data['post_title'] = sprintf( __( 'Draft created on %1$s at %2$s' ), gmdate( __( 'F j, Y' ), $now ), gmdate( __( 'g:i a' ), $now ) ); // OK.

WordPress/Tests/WP/TimezoneChangeUnitTest.php

@@ -30,6 +30,7 @@ class TimezoneChangeUnitTest extends AbstractSniffUnitTest {
 	public function getErrorList() {
 		return array(
 			3 => 1,
+			8 => 2,
 		);
 	}