-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(avatar): font size #1431
Open
RyushiAok
wants to merge
2
commits into
main
Choose a base branch
from
fix/avatar-font-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−54
Open
Fix(avatar): font size #1431
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@wizleap-inc/wiz-ui-react": minor | ||
"@wizleap-inc/wiz-ui-next": minor | ||
--- | ||
|
||
Fix(avatar): fallback font size を修正しました.これに伴い,size プロパティで指定可能な値を`"md" | "lg" | "xl" | "xl2" | "xl3" | "xl4"` のみに限定しました. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
:class="[ | ||
avatarStyle, | ||
sizeStyle[size], | ||
|
||
colorStyle[fontColor], | ||
clickable && avatarClickableStyle, | ||
]" | ||
|
@@ -18,7 +19,7 @@ | |
/> | ||
<div | ||
v-else | ||
:class="[avatarFallbackStyle]" | ||
:class="[avatarFallbackStyle, fontSizeStyle[fontSizeMap[size]]]" | ||
:style="{ | ||
background: avatarBgColor, | ||
}" | ||
|
@@ -30,20 +31,25 @@ | |
|
||
<script setup lang="ts"> | ||
import { | ||
getColorCss, | ||
ComponentName, | ||
ColorKeys, | ||
ComponentName, | ||
FontSizeKeys, | ||
SpacingKeys, | ||
THEME, | ||
getColorCss, | ||
} from "@wizleap-inc/wiz-ui-constants"; | ||
import { | ||
avatarStyle, | ||
avatarImageStyle, | ||
avatarFallbackStyle, | ||
avatarClickableStyle, | ||
avatarFallbackStyle, | ||
avatarImageStyle, | ||
avatarStyle, | ||
} from "@wizleap-inc/wiz-ui-styles/bases/avatar.css"; | ||
import { sizeStyle, colorStyle } from "@wizleap-inc/wiz-ui-styles/commons"; | ||
import { ref, PropType, computed } from "vue"; | ||
import { | ||
colorStyle, | ||
fontSizeStyle, | ||
sizeStyle, | ||
} from "@wizleap-inc/wiz-ui-styles/commons"; | ||
import { PropType, computed, ref } from "vue"; | ||
|
||
defineOptions({ | ||
name: ComponentName.Anchor, | ||
|
@@ -63,7 +69,9 @@ const props = defineProps({ | |
required: true, | ||
}, | ||
size: { | ||
type: String as PropType<SpacingKeys>, | ||
type: String as PropType< | ||
Extract<SpacingKeys, "md" | "lg" | "xl" | "xl2" | "xl3" | "xl4"> | ||
>, | ||
required: false, | ||
default: "xl3", | ||
}, | ||
|
@@ -131,4 +139,16 @@ const fontColor = computed(() => { | |
} | ||
return "white.800"; | ||
}); | ||
|
||
const fontSizeMap: Record< | ||
Extract<SpacingKeys, "md" | "lg" | "xl" | "xl2" | "xl3" | "xl4">, | ||
Extract<FontSizeKeys, "xs2" | "xs" | "sm" | "md" | "lg"> | ||
> = { | ||
md: "xs2", | ||
lg: "xs2", | ||
xl: "xs", | ||
xl2: "sm", | ||
xl3: "md", | ||
xl4: "lg", | ||
}; | ||
Comment on lines
+143
to
+153
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. この対応関係はvueとreactで共通なので、良い感じに共通化できるとよいですね…… |
||
</script> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
packages/wiz-ui-react/src/components/base/avatar/stories/avatar.stories.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちら一応majorです!