Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thread safety fixes #224

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Thread safety fixes #224

merged 2 commits into from
Feb 11, 2025

Conversation

HaHaWTH
Copy link
Member

@HaHaWTH HaHaWTH commented Feb 11, 2025 •
edited
Loading

This pull request fixes some thread safety bugs found in async features.

Changes

  • Fix AsyncMobSpawn
  • Fix MultithreadedTracker (ConcurrentLongHashSet)

To reproduce

  1. Set max-players to 50
  2. 50+ players join server at the same time
  3. See error

Logs

@HaHaWTH HaHaWTH requested a review from Dreeam-qwq February 11, 2025 16:54
@Dreeam-qwq Dreeam-qwq added the type: fix Pull request for fixing bug label Feb 11, 2025
@Dreeam-qwq Dreeam-qwq merged commit bdccf34 into Winds-Studio:ver/1.21.4 Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreeam-qwq Dreeam-qwq Dreeam-qwq approved these changes

Assignees
No one assigned
Labels
type: fix Pull request for fixing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaHaWTH @Dreeam-qwq