Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bunch of side perf improvements #217

Draft
wants to merge 63 commits into
base: ver/1.21.4
Choose a base branch
from
Draft

Bunch of side perf improvements #217

wants to merge 63 commits into from

Conversation

Taiyou06
Copy link
Collaborator

@Taiyou06 Taiyou06 commented Feb 7, 2025

This PR should add in-dev stuff that was left over in our private test repository. (Tramontane)

@Dreeam-qwq Dreeam-qwq added the type: optimization Pull request for optimization label Feb 7, 2025
@Taiyou06 Taiyou06 force-pushed the tramontane-stuff branch 2 times, most recently from ed9140d to d473e2d Compare February 8, 2025 03:40
@Taiyou06 Taiyou06 mentioned this pull request Feb 8, 2025
Closed
@Taiyou06
Copy link
Collaborator Author

Taiyou06 commented Feb 8, 2025 •
edited
Loading

34c1344

TODO: Seperate the tickets with "not removal delay" outside the array and "with remove delays". So we avoid and predicate tests.
Suggestion by: @MachineBreaker

@Taiyou06
Copy link
Collaborator Author

Taiyou06 commented Feb 8, 2025

f40f313
This commit simplifies the SortedArraySet impl by making it O(N) from O(N+1) from paper's implementation, key differences are:

  • Avoids writes via writePos check.
  • And all of the logic is in a single for loop.

@Dreeam-qwq
Copy link
Member

Great work, will cleanup later, also not need to merge new commits from main branch

Taiyou06 and others added 30 commits February 11, 2025 20:23
@Taiyou06
extra: optimize collectTickingChunks
f475093
@Taiyou06
remove quadTree optimization for now (will open a new PR just for that)
7bb0b19
@Taiyou06
temp: Lazily optimize isChunkNearPlayer
0a309fe
@Dreeam-qwq
Merge branch 'ver/1.21.4' into tramontane-stuff
e643643
@Dreeam-qwq
Merge branch 'ver/1.21.4' into tramontane-stuff
abbe9d0
@Dreeam-qwq
Inline filter & merge as a single loop
d32e9c6
@Dreeam-qwq
[ci skip] Add diff on change
802cb5c
@Taiyou06
extra: optimize everything but the testing itself on getEntities
49bd9ca
@Dreeam-qwq
[ci skip] cleanup
ff3a466
@Dreeam-qwq
Optimize chunkUnloadQueue
8e9ebd9
@Dreeam-qwq
Remove iterators from inventory
2053803
@Dreeam-qwq
[ci skip] Add TODOs
e2ef94c
@Taiyou06
i hate programming
e20fcbb
@Taiyou06
remove forEach
8bccbbd
@Taiyou06
extra: Alternative Brain Behaviour
001c28a
@Taiyou06
remove: opt getEntities + cache fluidOnEyes
ced4f93
@Taiyou06
extra: Improve checkDespawn - credits: @kidofcubes
4c408b3
@Taiyou06
extra: Improve pushEntity and getEntities
03486cf
@Taiyou06
yeet this
d9dd4fa
@Taiyou06
VERY EXPERIMENTAL: getEntities Optimization
8e6eb96
@Taiyou06
fix bunch of issues from getEntities patch
469e80b
@Taiyou06
extra: slightly optimize getNearestPlayer - credits: @kidofcubes
d33c0df
@Taiyou06
drop a patch for now (will open a new pr)
e2fdf06
@Taiyou06
move these to a new branch
f2f722f
@Taiyou06
fix and optimize checkDespawn patches
94a1b03
@Dreeam-qwq
Merge branch 'ver/1.21.4' into tramontane-stuff
e34c1ed
@Dreeam-qwq
Rebuild Patches
b09378a
@Dreeam-qwq
[ci skip] Update benchmark
d5acf18
@Dreeam-qwq
[ci skip] cleanup
7c62b8a
@Dreeam-qwq
Drop
a80dc6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreeam-qwq Dreeam-qwq Dreeam-qwq left review comments

Assignees
No one assigned
Labels
type: optimization Pull request for optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Taiyou06 @Dreeam-qwq @DoggySazHi