Items with - and + are not being pulled out of bags #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacing fix
Update Master Level 2
Use convenient iterator methods. PR feedback.
1) Add support for Exemplar Points 2) Partial rework of packets to both utilize the packets library, and to take advantage of last_incoming when it is first loaded 3) Partial rework of Key Item detection for Dynamis
Swap the order of unpack's arguments.
This reverts commit f8015a0.
Packets Update 0x063-Order 2
Add 0x0AD Incoming
Update Pointwatch.lua -- Exemplar Points
Dev -> Live
Update Mount Roulette to 3.1.0
Fix for Accolades (Unity points)
[fields.lua] Fix for Accolades
Adds the texts:draggable() function
Added Current TVR Mission.
Correct TVR `_junk` field.
Update fields.lua
Added items to slips libs for the 10 July, 2022 FFXI Update.
[Slips lib] Update for July 2022
Adding items to slips from the august 10 update
[slips lib] August 10, 2022 FFXI Update
Song name released via ffxi official YouTube channel video
Update setbgm.lua
Update EmpyPopTracker to 2.7.0
Strings isn't required
Remove strings method from libs/dialog
Added definition for which bag the linkshell is being equipped from.
Update fields.lua: Update 0x0E0 (Linkshell Equip)
Slot is a better name but we dont want to break existing code that relies on the name. This could be revisited later
The August 2022 update to the game added 4 new fields to the currencies menu. This update reflects that.
Added new currencies.
Will need double checking that SE didn't screw up and for the Slip Item ID to be added.
Sept 2022 messages update
Looks like any item with a hyphen (-) or plus sign (+) is not being pulled out of storage by this lua when these items are called via keybinds, macros, or commands. The imatch function uses gsub and in lua 5.1 this requires these special characters to be preceded by an escape character, %. I've added two lines to replace these characters with the appropriate text to find them on lookup. I'm not the most familiar with the string and table libraries of windower so there may be a better way to do this but I'm hoping this at least highlights the issue and provides a solution so someone may improve upon it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is specifically for a change to one file for Itemizer.
Looks like any item with a hyphen (-) or plus sign (+) is not being pulled out of storage by this lua when these items are called via keybinds, macros, or commands.
The imatch function uses gsub and in lua 5.1 this requires these special characters to be preceded by an escape character, %. I've added two lines to replace these characters with the appropriate text to find them on lookup. I did not see any items or foods with other irregular characters that need to be replaced and this only affects cases when the /item command it used via macro, command, or keybind.
I'm not the most familiar with the string and table libraries of windower so there may be a better way to do this but I'm hoping this at least highlights the issue and provides a solution so someone may improve upon it.
Also, was I right to do a pull request to dev or should I merge this into a different branch first? I've never submitted to this project before and will happily resubmit to another branch if there is a different process in place.