Skip to content

Commit

Permalink
fix: fix jquery error in firefox (#837)
Browse files Browse the repository at this point in the history
  • Loading branch information
kumachan-mis authored Mar 4, 2023
1 parent 9744926 commit defac38
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@

- File Viewer
- https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/class.pu
- `!include` directive: https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/state.pu
- `!include` directive: https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/including.pu
- `!includesub` directive: https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/subincluding.pu
- Issues: https://github.com/WillBooster/plantuml-visualizer/issues/54
- Pull Requests
- Added: https://github.com/WillBooster/plantuml-visualizer/pull/49/files
Expand All @@ -38,7 +39,8 @@

- GitHub Raw Files (only Chrome)
- https://raw.githubusercontent.com/WillBooster/plantuml-visualizer/master/puml-sample/class.pu
- `!include` directive: https://raw.githubusercontent.com/WillBooster/plantuml-visualizer/master/puml-sample/state.pu
- `!include` directive: https://raw.githubusercontent.com/WillBooster/plantuml-visualizer/master/puml-sample/including.pu
- `!includesub` directive: https://raw.githubusercontent.com/WillBooster/plantuml-visualizer/master/puml-sample/subincluding.pu
- IMPORTANT NOTE: any extension on Firefox cannot work on GitHub Raw Files due to https://bugzilla.mozilla.org/show_bug.cgi?id=1411641
- Local Files
- file:///C:/Users/XXX/Projects/plantuml-visualizer/puml-sample/class.pu
Expand All @@ -62,9 +64,9 @@ The visualization result of https://github.com/WillBooster/plantuml-visualizer/p

## Default Visualization Server

The default server is https://willbooster-plantuml.herokuapp.com
The default server is https://plantuml-service-willbooster.fly.dev
([source code](https://github.com/WillBooster/plantuml-service)).
You may check the PlantUML version via [this link](https://willbooster-plantuml.herokuapp.com/version).
You may check the PlantUML version via [this link](https://plantuml-service-willbooster.fly.dev/version).

You may use another **HTTPS** PlantUML server by changing settings in the configuration window.

Expand Down
2 changes: 1 addition & 1 deletion src/finder/github/gitHubFileViewFinder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export class GitHubFileViewFinder implements CodeFinder {
const $text = $texts.eq(i);
const $fileLines = $text.find('tr');
let fileText = [...Array.from({ length: $fileLines.length }).keys()]
.map((lineno) => $fileLines.eq(lineno).find("[id^='LC'").text() + '\n')
.map((lineno) => $fileLines.eq(lineno).find("[id^='LC']").text() + '\n')
.join('');
fileText = await this.preprocessIncludeDirective(webPageUrl, fileText);
fileText = await this.preprocessIncludeSubDirective(webPageUrl, fileText);
Expand Down

0 comments on commit defac38

Please sign in to comment.