fix: improve error handling

WillBooster · Dec 19, 2024 · 4ee9a51 · 4ee9a51
1 parent b400068
commit 4ee9a51
Showing 1 changed file with 24 additions and 16 deletions.
diff --git a/src/memoize.ts b/src/memoize.ts
@@ -112,18 +112,22 @@ export function memoizeFactory({
           }
         }
         cache.set(key, [result, now]);
-        try {
-          if (result instanceof Promise) {
-            void (async () => {
-              const promise = persistCache?.(key, now, await result) as unknown;
+        if (result instanceof Promise) {
+          void (async () => {
+            try {
+              const promise = persistCache?.(key, now, result) as unknown;
               if (promise instanceof Promise) promise.catch(noop);
-            });
-          } else {
+            } catch {
+              // do nothing.
+            }
+          });
+        } else {
+          try {
             const promise = persistCache?.(key, now, result) as unknown;
             if (promise instanceof Promise) promise.catch(noop);
+          } catch {
+            // do nothing.
           }
-        } catch {
-          // do nothing.
         }
 
         console.log(`Exiting getter ${String(context.name)}.`);
@@ -189,18 +193,22 @@ export function memoizeFactory({
           }
         }
         cache.set(key, [result, now]);
-        try {
-          if (result instanceof Promise) {
-            void (async () => {
-              const promise = persistCache?.(key, now, await result) as unknown;
+        if (result instanceof Promise) {
+          void (async () => {
+            try {
+              const promise = persistCache?.(key, now, result) as unknown;
               if (promise instanceof Promise) promise.catch(noop);
-            });
-          } else {
+            } catch {
+              // do nothing.
+            }
+          });
+        } else {
+          try {
             const promise = persistCache?.(key, now, result) as unknown;
             if (promise instanceof Promise) promise.catch(noop);
+          } catch {
+            // do nothing.
           }
-        } catch {
-          // do nothing.
         }
 
         console.log(`Exiting ${context ? `method ${String(context.name)}` : 'function'}.`);