Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(incentive): filter zero rewards from query #214

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

kerber0x
Copy link
Contributor

Description and Motivation

This PR improves the incentive rewards query by filtering the zero amount rewards. Instead, it returns an empty vector.

Related Issues

#212


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

@kerber0x kerber0x force-pushed the fix/close-incentive-position branch from 4bbad2c to 6bfe9b3 Compare July 18, 2023 12:05
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 99.52% and project coverage change: +0.04 🎉

Comparison is base (c6ee3e1) 94.56% compared to head (6bfe9b3) 94.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   94.56%   94.60%   +0.04%     
==========================================
  Files         208      208              
  Lines       22937    23138     +201     
==========================================
+ Hits        21690    21890     +200     
- Misses       1247     1248       +1     
Impacted Files Coverage Δ
...-network/vault_factory/src/execute/create_vault.rs 100.00% <ø> (ø)
...ub/pool-network/incentive/src/tests/integration.rs 97.80% <99.52%> (+0.14%) ⬆️
.../pool-network/incentive/src/queries/get_rewards.rs 98.41% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small sensible change.

@kerber0x kerber0x merged commit bb84549 into main Jul 18, 2023
@kerber0x kerber0x deleted the fix/close-incentive-position branch July 18, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants