fix: fee distributor claim floor fix

White-Whale-Defi-Platform · Jun 25, 2024 · 3e75ebf · 3e75ebf
1 parent 78df4e7
commit 3e75ebf
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/contracts/liquidity_hub/fee_distributor/Cargo.toml b/contracts/liquidity_hub/fee_distributor/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "fee_distributor"
-version = "0.9.3"
+version = "0.9.4"
 authors = ["Kerber0x <[email protected]>"]
 edition.workspace = true
 description = "Contract to distribute the fees collected by the Fee Collector."

diff --git a/contracts/liquidity_hub/fee_distributor/src/commands.rs b/contracts/liquidity_hub/fee_distributor/src/commands.rs
@@ -97,7 +97,9 @@ pub fn claim(deps: DepsMut, info: MessageInfo) -> Result<Response, ContractError
             }))?;
 
         for fee in epoch.total.iter() {
-            let reward = fee.amount * bonding_weight_response.share;
+            let reward = fee
+                .amount
+                .checked_mul_floor(bonding_weight_response.share)?;
 
             if reward.is_zero() {
                 // nothing to claim

diff --git a/contracts/liquidity_hub/fee_distributor/src/error.rs b/contracts/liquidity_hub/fee_distributor/src/error.rs
@@ -1,4 +1,6 @@
-use cosmwasm_std::{DivideByZeroError, OverflowError, StdError, Uint64};
+use cosmwasm_std::{
+    CheckedMultiplyFractionError, DivideByZeroError, OverflowError, StdError, Uint64,
+};
 use cw_utils::ParseReplyError;
 use semver::Version;
 use thiserror::Error;
@@ -53,6 +55,9 @@ pub enum ContractError {
     #[error("{0}")]
     ParseReplyError(#[from] ParseReplyError),
 
+    #[error("{0}")]
+    CheckedMultiplyFractionError(#[from] CheckedMultiplyFractionError),
+
     #[error("Attempt to migrate to version {new_version}, but contract is on a higher version {current_version}")]
     MigrateInvalidVersion {
         new_version: Version,