updating #7

ksingla025 · 2024-12-07T00:23:29Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

Add specific line by line info of high level changes in this PR.

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you add or update any necessary documentation?
Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
- Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

New Feature
Bugfix
Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

Related to # (issue)

* fix world size and don't mock Signed-off-by: Maanu Grover <[email protected]> * cleanup global state Signed-off-by: Maanu Grover <[email protected]> * check app state instead Signed-off-by: Maanu Grover <[email protected]> * fix syntax nemo logger test Signed-off-by: Maanu Grover <[email protected]> --------- Signed-off-by: Maanu Grover <[email protected]>

…ress` (#11016) * Revert "[NeMo-UX] Use custom `BatchProgress` class which does not restore states (#10383)" This reverts commit b5798de. * make megatron sampler return the total number of batches in the dataset Signed-off-by: ashors1 <[email protected]> --------- Signed-off-by: ashors1 <[email protected]>

* initial commit Signed-off-by: Piotr Kaminski <[email protected]> * create Quantizer for NeMo 2.0 Signed-off-by: Piotr Kaminski <[email protected]> * refactor Signed-off-by: Piotr Kaminski <[email protected]> * Call quantize on an unwrapped mcore model Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> * Add tests, adjust unwrapping Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> * fix export Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> * Apply isort and black reformatting Signed-off-by: artbataev <[email protected]> * Fix output_path argument for HF import Signed-off-by: Piotr Kamiński <[email protected]> * fix fabric ckpt loading Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> * code review suggestions Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> * remove unused import Signed-off-by: Piotr Kaminski <[email protected]> * use cnn dataset in github ci Signed-off-by: Piotr Kaminski <[email protected]> * applied code review Signed-off-by: Piotr Kaminski <[email protected]> * code review changes Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> * simplify interface for data iterator Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> * (partial) PP fix Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> --------- Signed-off-by: Piotr Kaminski <[email protected]> Signed-off-by: Laplasjan107 <[email protected]> Signed-off-by: Piotr Kamiński <[email protected]> Signed-off-by: artbataev <[email protected]> Co-authored-by: Piotr Kaminski <[email protected]> Co-authored-by: Laplasjan107 <[email protected]> Co-authored-by: artbataev <[email protected]>

…10875) * add token duration Signed-off-by: monica-sekoyan <[email protected]> * revert rnnt change Signed-off-by: monica-sekoyan <[email protected]> * add remove_extra_whitespaces arg to spe tokenizer Signed-off-by: monica-sekoyan <[email protected]> * add token duration retrieval Signed-off-by: monica-sekoyan <[email protected]> * add ignore_extra_whitespace to spe Signed-off-by: monica-sekoyan <[email protected]> * add compute_timestamp support for tdt Signed-off-by: monica-sekoyan <[email protected]> * fix config field name Signed-off-by: monica-sekoyan <[email protected]> * add refinement for tdt timestamps Signed-off-by: monica-sekoyan <[email protected]> * add segments timestamp support and refinement for ctc Signed-off-by: monica-sekoyan <[email protected]> * modify tests for ctc decoding timestamps Signed-off-by: monica-sekoyan <[email protected]> * add rnnt timestamp tests Signed-off-by: monica-sekoyan <[email protected]> * updated doc Signed-off-by: monica-sekoyan <[email protected]> * fix in test Signed-off-by: monica-sekoyan <[email protected]> * Apply isort and black reformatting Signed-off-by: monica-sekoyan <[email protected]> * fix of unicode char Signed-off-by: monica-sekoyan <[email protected]> * fix rnnt_decoding test Signed-off-by: monica-sekoyan <[email protected]> * workaround for tesst tokenizer Signed-off-by: monica-sekoyan <[email protected]> * Apply isort and black reformatting Signed-off-by: monica-sekoyan <[email protected]> * modify segments formation Signed-off-by: monica-sekoyan <[email protected]> * modify segments for ctc Signed-off-by: monica-sekoyan <[email protected]> * fix in ctc refinement Signed-off-by: monica-sekoyan <[email protected]> * Apply isort and black reformatting Signed-off-by: monica-sekoyan <[email protected]> * minor changes Signed-off-by: monica-sekoyan <[email protected]> * reverse offset change Signed-off-by: monica-sekoyan <[email protected]> * Apply isort and black reformatting Signed-off-by: monica-sekoyan <[email protected]> * warning mode=once Signed-off-by: monica-sekoyan <[email protected]> * Apply isort and black reformatting Signed-off-by: monica-sekoyan <[email protected]> * make ignore_extrawhitespaces false Signed-off-by: monica-sekoyan <[email protected]> * minor changes Signed-off-by: monica-sekoyan <[email protected]> * adjust changes to the tests Signed-off-by: monica-sekoyan <[email protected]> * modify prompt_formatter tests Signed-off-by: monica-sekoyan <[email protected]> * Apply isort and black reformatting Signed-off-by: monica-sekoyan <[email protected]> --------- Signed-off-by: monica-sekoyan <[email protected]> Signed-off-by: monica-sekoyan <[email protected]> Co-authored-by: monica-sekoyan <[email protected]>

* Basic online dynamic quantization with vLLM Signed-off-by: Jan Lasek <[email protected]> * Apply isort and black reformatting Signed-off-by: janekl <[email protected]> * vllm 0.6.3 updates Signed-off-by: Jan Lasek <[email protected]> * Pass quantization param in deploy_vllm_triton.py script Signed-off-by: Jan Lasek <[email protected]> --------- Signed-off-by: Jan Lasek <[email protected]> Signed-off-by: janekl <[email protected]> Co-authored-by: janekl <[email protected]>

* ci: Improve VM maintenance Signed-off-by: Oliver Koenig <[email protected]> * rename stuff Signed-off-by: Oliver Koenig <[email protected]> * title Signed-off-by: Oliver Koenig <[email protected]> * use team Signed-off-by: Oliver Koenig <[email protected]> * run on failure too Signed-off-by: Oliver Koenig <[email protected]> * fix Signed-off-by: Oliver Koenig <[email protected]> * yrdy Signed-off-by: Oliver Koenig <[email protected]> * f Signed-off-by: Oliver Koenig <[email protected]> * test Signed-off-by: Oliver Koenig <[email protected]> * fix Signed-off-by: Oliver Koenig <[email protected]> * f Signed-off-by: Oliver Koenig <[email protected]> * f Signed-off-by: Oliver Koenig <[email protected]> * f Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>

* add packed seq recipes Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * extraneous prefix Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> --------- Signed-off-by: Chen Cui <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: cuichenx <[email protected]> Co-authored-by: Pablo Garay <[email protected]>

* adapter inference first commit Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * Fix yaml serialization Signed-off-by: Hemil Desai <[email protected]> * add copyright header Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * revert accidental commit Signed-off-by: Chen Cui <[email protected]> --------- Signed-off-by: Chen Cui <[email protected]> Signed-off-by: cuichenx <[email protected]> Signed-off-by: Hemil Desai <[email protected]> Co-authored-by: cuichenx <[email protected]> Co-authored-by: Hemil Desai <[email protected]> Co-authored-by: Pablo Garay <[email protected]>

* ci: Switch to CPU only runner Signed-off-by: Oliver Koenig <[email protected]> * runner Signed-off-by: Oliver Koenig <[email protected]> * Raise EnvironmentError when CUDA is unavailable to prevent cuda-python failure Signed-off-by: Vladimir Bataev <[email protected]> * Fix error message Signed-off-by: Vladimir Bataev <[email protected]> * update Signed-off-by: Oliver Koenig <[email protected]> * fix Signed-off-by: Oliver Koenig <[email protected]> * finalize Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]> Signed-off-by: Vladimir Bataev <[email protected]> Co-authored-by: Vladimir Bataev <[email protected]>

Signed-off-by: Rauf <[email protected]>

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pablo-garay <[email protected]>

* ci: Send team alerts on specific keywords Signed-off-by: Oliver Koenig <[email protected]> * f Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>

* change timestamps tests Signed-off-by: Monica Sekoyan <[email protected]> * Apply isort and black reformatting Signed-off-by: monica-sekoyan <[email protected]> --------- Signed-off-by: Monica Sekoyan <[email protected]> Signed-off-by: monica-sekoyan <[email protected]> Co-authored-by: monica-sekoyan <[email protected]>

* Add qwen recipe * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * change to TP1 for small models Signed-off-by: Ao Tang <[email protected]> --------- Signed-off-by: suiyoubi <[email protected]> Signed-off-by: Ao Tang <[email protected]> Co-authored-by: suiyoubi <[email protected]>

* Add copyright notice * Apply isort and black reformatting Signed-off-by: pablo-garay <[email protected]> --------- Signed-off-by: pablo-garay <[email protected]> Co-authored-by: pablo-garay <[email protected]>

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pablo-garay <[email protected]>

* add deprecation note Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]>

…r models (#10924) * initial commit * adding example t5_generate.py * workable inference code * updating code * update cpde * workable solution for T5 tokenizer (we add 100 sentinel tokens when initializing tokenizer throug setting config, instead of adding after initialization) * separate autokenizer's changes to another PR * cleaning code * addressing Marc's comments * addressing Marc's reviews * update code after merge * small fix * Apply isort and black reformatting Signed-off-by: huvunvidia <[email protected]> --------- Signed-off-by: huvunvidia <[email protected]> Co-authored-by: Huy Vu2 <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: huvunvidia <[email protected]>

… in energon MultiModalSampleConfig (#11041) Signed-off-by: Guyue Huang <[email protected]> Co-authored-by: Guyue Huang <[email protected]>

* update width pruning example defaults Signed-off-by: Keval Morabia <[email protected]> * Update Dockerfile.ci Signed-off-by: Keval Morabia <[email protected]> * Undo CI version update Signed-off-by: Keval Morabia <[email protected]> --------- Signed-off-by: Keval Morabia <[email protected]>

#11061)

* Add recipe for sc1/sc2 * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * typo fixed --------- Signed-off-by: suiyoubi <[email protected]> Co-authored-by: suiyoubi <[email protected]>

* Add copyright notice * Add copyright notice

* wrap batch_sampler Signed-off-by: Farhad Ramezanghorbani <[email protected]> * Apply isort and black reformatting Signed-off-by: farhadrgh <[email protected]> * pass dataloader mode * Apply isort and black reformatting Signed-off-by: farhadrgh <[email protected]> * pass dataloader mode Signed-off-by: Farhad Ramezanghorbani <[email protected]> * pass dataloader mode Signed-off-by: Farhad Ramezanghorbani <[email protected]> * resolve conflict Signed-off-by: Farhad Ramezanghorbani <[email protected]> * change import Signed-off-by: Farhad Ramezanghorbani <[email protected]> --------- Signed-off-by: Farhad Ramezanghorbani <[email protected]> Signed-off-by: farhadrgh <[email protected]> Signed-off-by: Chen Cui <[email protected]> Co-authored-by: Chen Cui <[email protected]>

* llama3 finetuning perf recipes progress capture Signed-off-by: Valerie Sarge <[email protected]> * Small syntax fix Signed-off-by: Valerie Sarge <[email protected]> * syntax Signed-off-by: Valerie Sarge <[email protected]> * Apply isort and black reformatting Signed-off-by: vysarge <[email protected]> * Correct ddp setting Signed-off-by: Valerie Sarge <[email protected]> * Fix hasattr check Signed-off-by: Valerie Sarge <[email protected]> * bf16 grad Signed-off-by: Valerie Sarge <[email protected]> * Update configs for 8b + 70b Signed-off-by: Valerie Sarge <[email protected]> * Set wgrad_deferral_limit Signed-off-by: Valerie Sarge <[email protected]> --------- Signed-off-by: Valerie Sarge <[email protected]> Signed-off-by: vysarge <[email protected]> Co-authored-by: vysarge <[email protected]>

* Set TE spec name for NeMo to HF checkpoint converters Signed-off-by: Keval Morabia <[email protected]> * Apply isort and black reformatting Signed-off-by: kevalmorabia97 <[email protected]> * Update convert_falcon_nemo_to_hf.py Signed-off-by: Keval Morabia <[email protected]> --------- Signed-off-by: Keval Morabia <[email protected]> Signed-off-by: kevalmorabia97 <[email protected]> Co-authored-by: kevalmorabia97 <[email protected]>

Signed-off-by: Oliver Koenig <[email protected]>

* switch to NeMo 2.0 recipes Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * add NeMo 2.0 recipe support Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix unit tests Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix auto conf ci test Signed-off-by: dimapihtar <[email protected]> * remove unused imports Signed-off-by: dimapihtar <[email protected]> * Apply isort and black reformatting Signed-off-by: dimapihtar <[email protected]> * fix stlye Signed-off-by: dimapihtar <[email protected]> * fix typo Signed-off-by: dimapihtar <[email protected]> --------- Signed-off-by: dimapihtar <[email protected]> Signed-off-by: dimapihtar <[email protected]> Co-authored-by: dimapihtar <[email protected]>

* initial commit * adding all recipes and tests * add tests for 220m, 3b, 11b; runnable with example_nemorun_t5.py * restore test_llama3_70b.py * remove unused libraties * remove unused libraries * address Ali's comments * address Ali's comments * edit test_t5_3b.py * Apply isort and black reformatting Signed-off-by: huvunvidia <[email protected]> --------- Signed-off-by: huvunvidia <[email protected]> Co-authored-by: Huy Vu2 <[email protected]> Co-authored-by: huvunvidia <[email protected]>

* initial commit Signed-off-by: Piotr Kaminski <[email protected]> * cleanup Signed-off-by: Piotr Kaminski <[email protected]> * fix fabric num nodes Signed-off-by: Piotr Kaminski <[email protected]> * Apply isort and black reformatting Signed-off-by: Laplasjan107 <[email protected]> * make style coherent Signed-off-by: Piotr Kaminski <[email protected]> --------- Signed-off-by: Piotr Kaminski <[email protected]> Signed-off-by: Laplasjan107 <[email protected]> Co-authored-by: Piotr Kaminski <[email protected]> Co-authored-by: Laplasjan107 <[email protected]>

Signed-off-by: Oliver Koenig <[email protected]>

Signed-off-by: Shashank Verma <[email protected]>

…, and training micro-optimizations (#11058) * Canary 2 prompt formatter Signed-off-by: Piotr Żelasko <[email protected]> * autoregister canary2 prompt format Signed-off-by: Piotr Żelasko <[email protected]> * lift the restrictions in canary tokenizer Signed-off-by: Piotr Żelasko <[email protected]> * work around canary tokenizer Signed-off-by: Piotr Żelasko <[email protected]> * unit test + fix number of issues Signed-off-by: Piotr Żelasko <[email protected]> * Add Canary2 and Canary1 language name back compat Signed-off-by: Piotr Żelasko <[email protected]> * 16% speedup Canary training on 1GPU Signed-off-by: Piotr Żelasko <[email protected]> * Apply isort and black reformatting Signed-off-by: pzelasko <[email protected]> * Fixes for Canary loss masking in train and val Signed-off-by: Piotr Żelasko <[email protected]> * Simplified language codes back to Canary1 format but expanded to all ISO lang codes Signed-off-by: Piotr Żelasko <[email protected]> * Canary <0.5s inference fix via padding Signed-off-by: Piotr Żelasko <[email protected]> * Add Lhotse issue workaround Signed-off-by: Piotr Żelasko <[email protected]> * Make loss masking on prompt optional and disabled by default Signed-off-by: Piotr Żelasko <[email protected]> * Fix copyright notices Signed-off-by: Piotr Żelasko <[email protected]> * Make pnc optional Signed-off-by: Piotr Żelasko <[email protected]> --------- Signed-off-by: Piotr Żelasko <[email protected]> Signed-off-by: Piotr Żelasko <[email protected]> Signed-off-by: pzelasko <[email protected]> Co-authored-by: pzelasko <[email protected]>

* first commit Signed-off-by: Chen Cui <[email protected]> * refactor lora Signed-off-by: Chen Cui <[email protected]> * refactor lora Signed-off-by: Chen Cui <[email protected]> * refactor dora Signed-off-by: Chen Cui <[email protected]> * add lora linear layers for qkv and fc1 Signed-off-by: Chen Cui <[email protected]> * add sharded state dict Signed-off-by: Chen Cui <[email protected]> * clean up Signed-off-by: Chen Cui <[email protected]> * doc strings Signed-off-by: Chen Cui <[email protected]> * refactor Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * clean up Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * doc strings Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> * add ci Signed-off-by: Chen Cui <[email protected]> * typo Signed-off-by: Chen Cui <[email protected]> * Apply isort and black reformatting Signed-off-by: cuichenx <[email protected]> --------- Signed-off-by: Chen Cui <[email protected]> Signed-off-by: cuichenx <[email protected]> Co-authored-by: cuichenx <[email protected]>

* ci: Run secrets detector on merge-commit Signed-off-by: Oliver Koenig <[email protected]> * fix Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>

* chore(beep boop 🤖): Bump `MCORE_TAG=67a50f2...` (2024-11-28) Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Dennis <[email protected]> Signed-off-by: Victarry <[email protected]> Signed-off-by: Oliver Koenig <[email protected]> Co-authored-by: Zhenhuan Liu <[email protected]> Co-authored-by: Victarry <[email protected]> Co-authored-by: Dennis <[email protected]>

* Handle exception when importing RetroGPTChunkDatasets Signed-off-by: Guyue Huang <[email protected]> * Update baseline Signed-off-by: guyueh1 <[email protected]> * Revert "Update baseline" This reverts commit 21a4734. * Update baseline Signed-off-by: guyueh1 <[email protected]> * Revert "Update baseline" This reverts commit 8d35fcc. --------- Signed-off-by: Guyue Huang <[email protected]> Signed-off-by: guyueh1 <[email protected]> Co-authored-by: guyueh1 <[email protected]>

* add bert in nemo2 * Add bert loss * update bert with latest nemo * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * Bert update * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * import optimize * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * pylint * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * pylint * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * pylint * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * more comment * use lightning package * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * comments resolved * Add loss * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * Fix NaN loss when resume * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * add default for num_tokentypes * update forward output to be a dict * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * ReName to HuggingFace Bert Model * Add BertLarge * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * Add BERT Tests * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * typo * add exporter * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * Fix Unit Tests * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * add sig * rename pretraining dataset testing for bert * delete pretraining dataset testing for bert * resolve TE dependency * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * resolve TE dependency * resolve TE dependency * resolve TE dependency * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * resolve TE dependency * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> --------- Signed-off-by: suiyoubi <[email protected]> Co-authored-by: suiyoubi <[email protected]>

Previously if model_prefix wasn't part of model_state_dict, then the nemo_model_conversion_dict would contain keys that looked like `.decoder....` with an extra "." prefix. This just makes sure model_prefix isn't empty before adding the model_prefix in. Signed-off-by: Terry Kong <[email protected]>

…11471) * update restore from config for continual training Signed-off-by: yaoyu-33 <[email protected]> * update star coder yaml Signed-off-by: yaoyu-33 <[email protected]> --------- Signed-off-by: yaoyu-33 <[email protected]>

* Update dist_ckpt.rst with best practices Signed-off-by: FortunaZhang <[email protected]> * Update dist_ckpt.rst with best practices Signed-off-by: FortunaZhang <[email protected]> * Add files via upload Signed-off-by: FortunaZhang <[email protected]> * Update dist_ckpt.rst per reviewer suggestions Signed-off-by: FortunaZhang <[email protected]> * Update dist ckpt image source to Release assets Signed-off-by: FortunaZhang <[email protected]> * Update dist_ckpt.rst Signed-off-by: FortunaZhang <[email protected]> --------- Signed-off-by: FortunaZhang <[email protected]>

…ec (#11189) * fix: regular torch optims (e.g., sgd) no longer error with closure spec Signed-off-by: Terry Kong <[email protected]> * address style Signed-off-by: Terry Kong <[email protected]> * revert old pop Signed-off-by: Terry Kong <[email protected]> * Update nemo/core/optim/optimizer_with_main_params.py Co-authored-by: Ananth Subramaniam <[email protected]> Signed-off-by: Terry Kong <[email protected]> Signed-off-by: Terry Kong <[email protected]> * refine comment Signed-off-by: Terry Kong <[email protected]> --------- Signed-off-by: Terry Kong <[email protected]> Signed-off-by: Terry Kong <[email protected]> Co-authored-by: Ananth Subramaniam <[email protected]>

Signed-off-by: Oliver Koenig <[email protected]>

* Init with parallelism validation * Apply isort and black reformatting Signed-off-by: BoxiangW <[email protected]> * Add config checks * Apply isort and black reformatting Signed-off-by: BoxiangW <[email protected]> * fix * Add unit tests on configs validation * Add test * Add copyright * Change test * testing * Test --------- Signed-off-by: BoxiangW <[email protected]> Co-authored-by: BoxiangW <[email protected]>

* fix finetuning PP Signed-off-by: Chen Cui <[email protected]> * refactor to avoid setting a class attribute in a class property Signed-off-by: Chen Cui <[email protected]> * Fix CI test script Signed-off-by: Chen Cui <[email protected]> --------- Signed-off-by: Chen Cui <[email protected]>

Signed-off-by: Ante Jukić <[email protected]>

* config hierarchy Signed-off-by: Malay Nagda <[email protected]> * better formatting Signed-off-by: Malay Nagda <[email protected]> * structure change Signed-off-by: Malay Nagda <[email protected]> * structure change Signed-off-by: Malay Nagda <[email protected]> * correct link Signed-off-by: Malay Nagda <[email protected]> * location for config map Signed-off-by: Malay Nagda <[email protected]> --------- Signed-off-by: Malay Nagda <[email protected]>

…ather (#11486) * Add disable/enable forward pre hook for DDP and overlap param gather Signed-off-by: Hemil Desai <[email protected]> * Fix Signed-off-by: Hemil Desai <[email protected]> * Force param sync before saving checkpoint Signed-off-by: Hemil Desai <[email protected]> * fix Signed-off-by: Hemil Desai <[email protected]> * Apply isort and black reformatting Signed-off-by: hemildesai <[email protected]> --------- Signed-off-by: Hemil Desai <[email protected]> Signed-off-by: hemildesai <[email protected]> Co-authored-by: hemildesai <[email protected]>

maanug-nv and others added 30 commits October 25, 2024 10:08

added Lhotse online augmentation tutorial for SE (#10944)

60b4ac7

Signed-off-by: Rauf <[email protected]>

[🤠]: Howdy folks, let's bump Dockerfile.ci to 397e9da ! (#11051)

8fcd5cb

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pablo-garay <[email protected]>

ci: Send team alerts on specific keywords (#10986)

0c5f5fb

* ci: Send team alerts on specific keywords Signed-off-by: Oliver Koenig <[email protected]> * f Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>

Add copyright notice (#11050)

7e036e6

* Add copyright notice * Apply isort and black reformatting Signed-off-by: pablo-garay <[email protected]> --------- Signed-off-by: pablo-garay <[email protected]> Co-authored-by: pablo-garay <[email protected]>

[🤠]: Howdy folks, let's bump Dockerfile.ci to d357c18 ! (#11054)

63fab97

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: pablo-garay <[email protected]>

[Bug fix] use default_factory to provide default value in dataclasses…

869625e

… in energon MultiModalSampleConfig (#11041) Signed-off-by: Guyue Huang <[email protected]> Co-authored-by: Guyue Huang <[email protected]>

fix: Resolve mutable default issue in MultiModalSampleConfig dataclass (

5d3dadb

#11061)

SC1/SC2 Recipe (#10971)

6597517

* Add recipe for sc1/sc2 * Apply isort and black reformatting Signed-off-by: suiyoubi <[email protected]> * typo fixed --------- Signed-off-by: suiyoubi <[email protected]> Co-authored-by: suiyoubi <[email protected]>

Add copyright notice (#11066)

aa68246

* Add copyright notice * Add copyright notice

ci: Re-add secrets detector (#11038)

3209aea

Signed-off-by: Oliver Koenig <[email protected]>

ko3n1g and others added 20 commits December 4, 2024 22:07

ci: Disable HexHighEntropyString plugin (#11470)

ae5c44c

Signed-off-by: Oliver Koenig <[email protected]>

Fix broken link (#11294)

c50200a

Signed-off-by: Shashank Verma <[email protected]>

ci: Run secrets detector on merge-commit (#11479)

d32d2c5

* ci: Run secrets detector on merge-commit Signed-off-by: Oliver Koenig <[email protected]> * fix Signed-off-by: Oliver Koenig <[email protected]> --------- Signed-off-by: Oliver Koenig <[email protected]>

Formatting (minor) (#11485)

02ad5da

Fix bug related to naming (#11487)

453a515

ci: Re-enable L2_Megatron_LM_To_NeMo_Conversion (#11484)

7740081

Signed-off-by: Oliver Koenig <[email protected]>

Documentation for audio collection (#11426)

4f2c1be

Signed-off-by: Ante Jukić <[email protected]>

ksingla025 merged commit 258f804 into WhissleAI:main Dec 7, 2024
4 of 6 checks passed

github-actions bot added ASR NLP Multi Modal TTS core common CI Audio Speaker Tasks labels Dec 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updating #7

updating #7

ksingla025 commented Dec 7, 2024

updating #7

updating #7

Conversation

ksingla025 commented Dec 7, 2024

What does this PR do ?

Changelog

Usage

GitHub Actions CI

Before your PR is "Ready for review"

Who can review?

Additional Information