Example for delegation with multisig #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #148 +/- ##
============================================
Coverage 81.42% 81.42%
============================================
Files 46 46
Lines 4141 4141
Branches 1030 1030
============================================
Hits 3372 3372
Misses 737 737
Partials 32 32 ☔ View full report in Codecov by Sentry. |
|
Hi @nkongsuwan |
|
@psteniusubi Yes, I just removed the witnesses, and the scripts now work! |
|
@nkongsuwan This script looks good, but can you convert it to run as part of the integration suite? |
nkongsuwan
force-pushed
the
example-delegation-multisig
branch
from
895ec4a to
9c7509a
Compare
|
@pfeairheller I have modified it so that it is compatible with Jest. However, it still somehow breaks at the OOBI verification. |
nkongsuwan
force-pushed
the
example-delegation-multisig
branch
from
c02e182 to
9b6336b
Compare
Signed-off-by: Nuttawut Kongsuwan <[email protected]>
nkongsuwan
force-pushed
the
example-delegation-multisig
branch
from
96bc7c4 to
623f479
Compare
lenkan
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an example for delegation with multisig with one delegator and two delegatees.
However, the last step currently does not work. The delegatees do not receive the approval from the delegator. I suspect it has something to do with the payload in the exchange message between delegatee members.
Edit: The problem is related to Issue #145. The script just works if I remove the delegatees' witnesses.