Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove name parameter from exchanges.get method #141

Merged

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Nov 16, 2023

Please merge this only if you decide to merge the corresponding PR in keria WebOfTrust/keria#128.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (645d665) 81.01% compared to head (9725ede) 81.01%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #141   +/-   ##
============================================
  Coverage        81.01%   81.01%           
============================================
  Files               46       46           
  Lines             4187     4187           
  Branches          1028     1028           
============================================
  Hits              3392     3392           
  Misses             763      763           
  Partials            32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m00sey m00sey merged commit bcd83fc into WebOfTrust:development Nov 21, 2023
4 checks passed
@lenkan lenkan deleted the fix-removal-exchanges-name-parameter branch December 4, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants