Avoid :has selector in CSS. #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes how section visibility is controlled. All sections are still `display:none` by default. Rather than becoming `display:block` when they match `:target`, they now become `display:block` if their ID matches the value of the root element's `data-visible-section` attribute - we hardcode the four section names "home", "running", "summary" and "details". This lets us default to the home section just by setting `<html data-visible-section="home">` in index.html, and we can avoid the `:has` selector. Now Speedometer can run in older browsers which don't support `:has`.
mstange
force-pushed
the
no-target-pseudoclass
branch
from
9b4290e to
5a6c9a8
Compare
rniwa
approved these changes
Mar 6, 2024
julienw
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Looks good to me. IMO It's also simple enough to land in v3.0 but of course please test it in your respective browsers. (I tested myself in firefox nightly, stable and esr, as well as chrome dev and stable)
At this point the hash is only useful so that we can press back/forward buttons between the summary and details views. Is it worth the extra code? (Question for v3.1)
camillobruni
approved these changes
Mar 6, 2024
flashdesignory
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394.
This changes how section visibility is controlled. All sections are still
display:noneby default.Rather than becoming
display:blockwhen they match:target, they now becomedisplay:blockif their ID matches the value of the root element'sdata-visible-sectionattribute - we hardcode the four section names "home", "running", "summary" and "details".This lets us default to the home section just by setting
<html data-visible-section="home">in index.html, and we can avoid the:hasselector.Now Speedometer can run in older browsers which don't support
:has.