Skip to content

Commit

Permalink
[MDB Ignore] Adds a unit test for typepaths that are required to be m…
Browse files Browse the repository at this point in the history
…apped onto each station map (tgstation#74985)

## About The Pull Request

Inspired by tgstation#74967 and tgstation#68459 , and the fact that Tramstation regresses
very often -

Adds a unit test, `required_map_items`, which ensures that certain
typepaths which should definitely be mapped onto every map is mapped
onto every map

It can also be used to ensure that items which should not be mapped in
multiple times are not, among other things.

I included a few examples - 
- Min 1, max inf of each head of staff stamps
- Min 1, max 1 departmental order consoles
- Min 1, max inf comms console
- Min 1, max 1 Pun Pun
- Min 1, max 1 Poly
- Min 1, max 1 Ian

If, in the future, a mapper decides they (for some reason) do not want a
certain previously-required item on their map, the test can be adjusted
such that it allows excluding or something, but currently it should be
for items which require conscious thought about.

#### QA: Why not make this a linter?

I attempted to make this a linter before realizing two things
1. Someone might make a spawner which spawns the items, or they might
get placed in a locker, in any case this accounts for everything on init
2. Linters run on every map, non-station maps included

So I went with a test

## Why It's Good For The Game

tgstation#50468
tgstation#61013
tgstation#74967

Why is it always the CMO stamp?

## Changelog

Not necessary (unless I find a map missing something, then this will be
updated)
  • Loading branch information
MrMelbert authored May 4, 2023
1 parent 7aef07f commit 4de3df4
Show file tree
Hide file tree
Showing 36 changed files with 193,686 additions and 193,573 deletions.
2 changes: 1 addition & 1 deletion _maps/RandomRuins/SpaceRuins/hilbertresearchfacility.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,7 @@
"BL" = (
/obj/structure/table/wood,
/obj/item/folder/white,
/obj/item/stamp/rd,
/obj/item/stamp/head/rd,
/turf/open/floor/iron/grimy,
/area/ruin/space/has_grav/powered/hilbertresearchfacility)
"BM" = (
Expand Down
Loading

0 comments on commit 4de3df4

Please sign in to comment.