Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] 게시물 좋아요 API #17

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

[feature] 게시물 좋아요 API #17

wants to merge 9 commits into from

Conversation

dyori04
Copy link
Contributor

@dyori04 dyori04 commented Oct 28, 2023 •
edited
Loading

관련 Issue

변경 사항

  • 게시물 좋아요 API 구현
  • web Client Config 추가

Todo List

  • 테스트 데이터를 통한 작동 테스트 (완료)
  • 테스트 코드 작성
  • Postman 테스트 (완료)

@github-actions
Copy link

github-actions bot commented Oct 28, 2023 •
edited
Loading

Test Results

1 tests  ±0   1 ✔️ ±0   0s ⏱️ ±0s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 1bbf127. ± Comparison against base commit d4e5b47.

♻️ This comment has been updated with latest results.

@dyori04 dyori04 requested review from 9898s, rivkode and JisooPyo October 28, 2023 14:30
@dyori04 dyori04 added the feature New feature or request label Oct 28, 2023
@dyori04 dyori04 self-assigned this Oct 28, 2023
@JisooPyo JisooPyo added the WIP Work In Progress label Oct 28, 2023
@dyori04 dyori04 removed the WIP Work In Progress label Oct 31, 2023
9898s
9898s reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@9898s 9898s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dyori04 님! 리뷰 남겼습니다.
수고 많으셨습니다!

src/main/java/com/snsIntegrationFeedService/post/service/PostService.java
statusCode = HttpStatus.NOT_FOUND;
}
break;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중복된 부분은 메서드 하나 만들어서 처리 해주는게 좋아보입니다.

rivkode
rivkode approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@rivkode rivkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge 승인

@dyori04 정석님 수고하셨습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9898s 9898s 9898s left review comments

@rivkode rivkode rivkode approved these changes

@JisooPyo JisooPyo Awaiting requested review from JisooPyo

At least 2 approving reviews are required to merge this pull request.

Assignees

@dyori04 dyori04

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyori04 @9898s @rivkode @JisooPyo