Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] README 생성 #38

Merged
merged 5 commits into from
Nov 20, 2023
Merged

[docs] README 생성 #38

merged 5 commits into from
Nov 20, 2023

Conversation

rivkode
Copy link
Member

@rivkode rivkode commented Nov 18, 2023 •
edited by JisooPyo
Loading

관련 Issue

변경 사항

  • README 생성

Todo List

  • swagger 추가

@rivkode rivkode added the documentation Improvements or additions to documentation label Nov 18, 2023
@rivkode rivkode self-assigned this Nov 18, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 18, 2023 •
edited
Loading

Test Results

9 tests  ±0   9 ✔️ ±0   1s ⏱️ -1s
4 suites ±0   0 💤 ±0 
4 files   ±0   0 ❌ ±0 

Results for commit 6805a11. ± Comparison against base commit 835be59.

♻️ This comment has been updated with latest results.

9898s
9898s approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@9898s 9898s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

JisooPyo
JisooPyo approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@JisooPyo JisooPyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 깔끔해서 보기 좋았어요! 다만 트러블 슈팅의 경우 회원가입, 로그인 이런 식으로 PR을 거는 것이 아니라 "~~한 문제 해결"로 링크를 걸어주시는 게 더 좋을 것 같아요! 일단 승인하겠습니다!

@JisooPyo JisooPyo linked an issue Nov 20, 2023 that may be closed by this pull request
[docs] README 작성 #20
Closed
@JisooPyo JisooPyo merged commit 6420b88 into develop Nov 20, 2023
3 checks passed
@JisooPyo JisooPyo deleted the docs/20/readme branch November 20, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JisooPyo JisooPyo JisooPyo approved these changes

@9898s 9898s 9898s approved these changes

@dyori04 dyori04 Awaiting requested review from dyori04

Assignees

@rivkode rivkode

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] README 작성
3 participants
@rivkode @9898s @JisooPyo