[refactor] raw restaurant 데이터 갱신 속도 개선 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
JisooPyo
reviewed
Nov 10, 2023
...main/java/com/locationbasedfoodieservice/rawrestaurant/scheduler/RawRestaurantScheduler.java
Show resolved
Hide resolved
Comment on lines
+29
to
+32
| jdbcTemplate.batchUpdate(sql, | ||
| rawRestaurants, | ||
| rawRestaurants.size(), | ||
| (PreparedStatement ps, RawRestaurant rawRestaurant) -> { |
There was a problem hiding this comment.
PreparedStatement 를 사용하면 장점이 여러개 있군요 !
- 가독성과 유지보수
- 쿼리 실행계획 재사용으로 parse과정을 최초로 한 번만 수행 이후 캐싱
- SQL 인잭션 취약점 보안
Comment on lines
-18
to
-19
| @Table(uniqueConstraints = | ||
| {@UniqueConstraint(columnNames = {"bizplcNm", "refineZipCd"})}) |
There was a problem hiding this comment.
어차피 Restaurant에서 유일키가 있으니까 이 부분은 UK를 걸어주지 않아도 됐었겠네요! 좋아요!
JisooPyo
approved these changes
Nov 10, 2023
rivkode
approved these changes
Nov 19, 2023
Comment on lines
+29
to
+32
| jdbcTemplate.batchUpdate(sql, | ||
| rawRestaurants, | ||
| rawRestaurants.size(), | ||
| (PreparedStatement ps, RawRestaurant rawRestaurant) -> { |
There was a problem hiding this comment.
PreparedStatement 를 사용하면 장점이 여러개 있군요 !
- 가독성과 유지보수
- 쿼리 실행계획 재사용으로 parse과정을 최초로 한 번만 수행 이후 캐싱
- SQL 인잭션 취약점 보안
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 Issue
변경 사항