Skip to content

Commit

Permalink
TRUNK-5301 Remove org.openmrs.arden resources
Browse files Browse the repository at this point in the history
* remove checkstyle-suppressions which are not needed anymore
* remove antlr plugin running arden from api pom
  • Loading branch information
teleivo committed Jan 4, 2018
1 parent 40e5571 commit b59ec43
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 76 deletions.
9 changes: 0 additions & 9 deletions api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -275,15 +275,6 @@
</excludes>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>antlr-maven-plugin</artifactId>
<version>2.1</version>
<configuration>
<outputDirectory>src/main/java</outputDirectory>
<grammars>ArdenRecognizer.g</grammars>
</configuration>
</plugin>
<plugin>
<groupId>com.googlecode.maven-java-formatter-plugin</groupId>
<artifactId>maven-java-formatter-plugin</artifactId>
Expand Down
68 changes: 1 addition & 67 deletions checkstyle-suppressions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -17,73 +17,7 @@

<suppressions>

<!--
Allow arden grammar-generated classes to use unconvential parameter
names
-->
<suppress checks="ParameterName" files="ArdenBaseLexer.java" />
<suppress checks="ParameterName" files="ArdenBaseTreeParser.java" />

<!-- Exception for arden compiled rules still in the repository -->
<suppress checks=".*" files=".*/arden/compiled/.*" />

<!--
Exception for arden auto-generated classes that don't yet include
MPL 2.0 HD header
-->
<suppress checks="Header" files="ArdenBaseLexer.java" />
<suppress checks="Header" files="ArdenBaseParser.java" />
<suppress checks="Header" files="ArdenBaseParserTokenTypes.java" />
<suppress checks="Header" files="ArdenBaseTreeParser.java" />
<suppress checks="Header" files="ArdenBaseTreeParserTokenTypes.java" />

<!-- Exceptions for line length longer than 125 -->
<suppress checks="FileLength" files="ArdenBaseParser.java" />
<suppress checks="FileLength" files="ArdenBaseTreeParser.java" />

<!-- Exceptions for use of ex.printStackTrace() -->
<suppress id="IllegalPrintStackTrace" files="MLMObject.java" />

<!-- Exceptions for line length longer than 125 -->
<suppress checks="LineLength" files="ArdenBaseLexer.java" />
<suppress checks="LineLength" files="ArdenBaseParser.java" />
<suppress checks="LineLength" files="ArdenBaseTreeParser.java" />
<suppress checks="LineLength" files="ArdenServiceImpl.java" />

<!-- Exceptions for method length conventions -->
<suppress checks="MethodLength" files="ArdenBaseParser.java" />
<suppress checks="MethodLength" files="ArdenBaseTreeParser.java" />
<suppress checks="MethodLength" files="ArdenServiceImpl.java" />

<!-- Exceptions for method naming conventions -->
<suppress checks="MethodName" files="ArdenBaseLexer.java" />
<suppress checks="MethodName" files="ArdenBaseParser.java" />
<suppress checks="MethodName" files="ArdenBaseTreeParser.java" />
<suppress checks="MethodName" files="ArdenClause.java" />
<suppress checks="MethodName" files="ArdenValue.java" />
<!-- Test classes are allowed to have underscores in method names -->
<suppress checks="MethodName" files="\*Test.java" />

<!--
Exceptions for throwing Throwable, Exception, or RuntimeException
-->
<suppress checks="IllegalThrows" files="ArdenServiceImpl.java" />
<suppress checks="IllegalThrows" files="MLMObject.java" />

<!-- Exception for classes without class-level Javadoc comment -->
<suppress checks="JavadocType" files="ArdenBaseParser.java" />
<suppress checks="JavadocType" files="ArdenBaseParserTokenTypes.java" />
<suppress checks="JavadocType" files="ArdenBaseTreeParserTokenTypes.java" />
<suppress checks="JavadocType" files="ArdenClause.java" />
<suppress checks="JavadocType" files="ArdenDataSource.java" />
<suppress checks="JavadocType" files="ArdenRule.java" />
<suppress checks="JavadocType" files="ArdenService.java" />
<suppress checks="JavadocType" files="ArdenValue.java" />

<!-- Exceptions for left curly brace convention -->
<suppress checks="LeftCurly" files="ArdenServiceImpl.java" />

<!-- Exceptions for operator wrapping -->
<suppress checks="OperatorWrap" files="ArdenServiceImpl.java" />

</suppressions>
</suppressions>

0 comments on commit b59ec43

Please sign in to comment.