Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangouts/meeting feature #46

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from

Conversation

Upasanadhameliya
Copy link
Contributor

Closes #45

Hangouts index page will be used to display all the hangouts
and will also be used to create new hangouts in order for people
to collaborate.
The cards are made to be clickable which would subsequently
render individual hangouts pages.

Also made the url to be a streamfield url block
@Upasanadhameliya

This comment has been minimized.

project/hangouts/models.py Outdated Show resolved Hide resolved
project/hangouts/models.py Outdated Show resolved Hide resolved
@brylie
Copy link
Collaborator

brylie commented Dec 7, 2021

OK, the PR code should work now. I reset the migrations and flattened the Hangout model hierarchy. I also needed to add some safety checks around our <Model>.objects.get() methods since they will throw an ObjectDoesNotExist error when no model object exists.

project/hangouts/models.py Outdated Show resolved Hide resolved
Get Topics property fetches all the topics and displays them
on the respective hangouts pages.
Made use of RoutablePageMixin to route pages to url of /topics/<topic-slug>.
Only those hangouts which are available in the selected topic will be rendered.
@brylie
Copy link
Collaborator

brylie commented Dec 8, 2021

One thing to consider is that, by default, Codebuddies hangouts use Jitsi Meet. The hangout_url field would be optional and an alternative to Jitsi Meet. So, we might think about telling users the default hangout uses Jitsi Meet unless they specify an alternative hangout URL. Likewise, the template should show an embedded Jitsi Meet room unless the hangout_url is set. In the latter case, we can create a large button like "join the hangout."

Added translate tags
Topics selected can be cleared using "clear" button
project/hangouts/models.py Outdated Show resolved Hide resolved
project/hangouts/models.py Outdated Show resolved Hide resolved
Iterating this way is not recommended when there is a huge amount
of data in the database, as it slows down the retrieval.
Made use of tag filtering with distinct() to fetch the topics
and separated out the function that appended url to the topic
@brylie
Copy link
Collaborator

brylie commented Jun 24, 2022

@Upasanadhameliya, I believe this pull request is ready for review, correct?

@Upasanadhameliya
Copy link
Contributor Author

Upasanadhameliya commented Jun 24, 2022

@brylie I don't think so, the templates part is yet to be added. Sorry for the delay, I will resume working on it soon enough :))

@brylie
Copy link
Collaborator

brylie commented Jun 25, 2022

All good, no hurry. I'm available now to help as well. Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "online hangout/meeting" feature
2 participants