Update/site options schema properties 2 #9
Conversation
|
@fjarrett this is ready to merge :) |
| 'title' => array( | ||
| 'description' => __( 'Site Title' ), | ||
|
|
||
| // Reference: https://docs.google.com/spreadsheets/d/1vI-s8MjbEllCR0_0BmBgaGvKNm1Fa42MCoqaKCwbRyQ/edit#gid=0 |
There was a problem hiding this comment.
Please remove this code comment.
|
@kjbenk Can you make sure there are tests for each of these? |
| 'type' => 'string', | ||
| 'screen' => 'discussion', | ||
| 'context' => array( 'view', 'edit' ), | ||
| 'public' => true, |
There was a problem hiding this comment.
I'm not sure it makes sense to introduce new screen and public attributes in the schema.
There was a problem hiding this comment.
I agree that maybe the screen attribute is not that useful but since some options are private and others are public we will need a mapping system to determine what options can be retrieved as an unauthenticated user...right?
There was a problem hiding this comment.
ill need a mapping system to determine what options can be retrieved as an unauthenticated user...right?
Right — that's context. view means "frontend", and edit means "editor" (or backend).
There was a problem hiding this comment.
Ah ok...that makes more sense now. I will remove the public and screen attribute.
* UPDATED: The unit test to check for the item schema has been updated to account for all the site options
* REMOVED: Screen and public attribute from each property
Adds all the site options based on the google sheet.
https://docs.google.com/spreadsheets/d/1vI-s8MjbEllCR0_0BmBgaGvKNm1Fa42MCoqaKCwbRyQ/edit#gid=0