Skip to content

Commit

Permalink
REFACTOR(project) :: member Dto들 record로 변경
Browse files Browse the repository at this point in the history
  • Loading branch information
Woongbin06 committed Oct 1, 2024
1 parent 779a36a commit 9011d10
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 35 deletions.
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
package com.woongeya.zoing.domain.project.presetation.dto.request;

import lombok.AllArgsConstructor;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Getter
@AllArgsConstructor
@NoArgsConstructor
public class MemberRequestDto {

private Long memberId;
public record MemberRequestDto (
Long memberId
) {
}
Original file line number Diff line number Diff line change
@@ -1,23 +1,13 @@
package com.woongeya.zoing.domain.project.presetation.dto.response;

import com.woongeya.zoing.domain.project.domain.Member;
import com.woongeya.zoing.domain.user.domain.User;
import lombok.Builder;
import lombok.Getter;

@Getter
@Builder
public class MemberResponseDto {

private Long userId;
private String name;
private String imgUrl;

public static MemberResponseDto of(User user) {
return MemberResponseDto.builder()
.userId(user.getId())
.name(user.getName())
.imgUrl(user.getImgUrl())
.build();
public record MemberResponseDto (
Long userId,
String name,
String imgUrl
){
public static MemberResponseDto from(User user) {
return new MemberResponseDto(user.getId(), user.getName(), user.getImgUrl());
}
}
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
package com.woongeya.zoing.domain.project.service;

import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

import com.woongeya.zoing.domain.project.domain.Member;
import com.woongeya.zoing.domain.project.domain.repository.CustomMemberRepository;
import com.woongeya.zoing.domain.project.domain.repository.MemberRepository;
import com.woongeya.zoing.domain.project.exception.IsNotWriterException;
import com.woongeya.zoing.domain.project.exception.MemberNotFoundException;
import com.woongeya.zoing.domain.project.presetation.dto.request.MemberRequestDto;
import com.woongeya.zoing.domain.user.UserFacade;
import com.woongeya.zoing.domain.user.domain.User;

import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

@Service
@RequiredArgsConstructor
Expand All @@ -30,9 +31,6 @@ public void execute(Long id, MemberRequestDto request) {
}

member.getProject().decreaseCurrentPeople();
memberRepository.delete(
memberRepository.findById(request.getMemberId())
.orElseThrow(() -> MemberNotFoundException.EXCEPTION)
);
memberRepository.deleteById(request.memberId());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public List<MemberResponseDto> execute(Long id) {
.collect(Collectors.toList());

return users.stream()
.map(MemberResponseDto::of)
.map(MemberResponseDto::from)
.collect(Collectors.toList());
}
}

0 comments on commit 9011d10

Please sign in to comment.