Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional slot-size parameters to trustedBiddingSignalsURL requests #928
Add optional slot-size parameters to trustedBiddingSignalsURL requests #928
Changes from 12 commits
ce4855a
ce59178
f229705
4eefec4
c9af021
5bdac81
dc11454
1a4d6ae
462c55d
6be6a4d
6197823
e0c924b
edb343e
eeedda9
fa000ea
6f45465
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all these different units are a little more distracting than helpful. Maybe just list two ad sizes here, one matching this requestedSize and one not? The available units can go down in the text where you talk about normalization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not going to trim or rework the sizeGroups section in this CL, as I have no idea what a size group is, and that's really beyond the scope of this PR, so I am not going to trim down the adSizes block.
This PR is also not introducing the ad sizes units, and I'm not really very familiar with them, anyways, so I'm reluctant to dig into them here. I've just removed all the units. I'll leave mucking with them for another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disconnect between the illustrative URL
&slot-size=100,200
and the paragraph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first is a sample URL, rather than a template. The second is telling you the what the values mean. This is really the only place we explicitly mention that width is first (admittedly, the next line demonstrates it is), so I think this is probably the way to go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to the parameter name disconnect, which in either case is supposed to have fidelity to what Chrome will fetch, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely missed that. You're correct - and this is actually a bug in the current implementation. It should be using camelCase like everything else, but it is not. Thanks so much for catching this before we shipped anything! (Well, mostly - it's enabled on Canary with the wrong value). The all-slots-requested-sizes string also doesn't match the implementation. Anyhow, both issues should be fixed (Though still need to fix Chrome itself)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're welcome. I'll follow the bug you filed.