Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Some Clarity Around the URL Validations #755

Merged

Conversation

thegreatfatzby
Copy link
Contributor

Ended up digging through the code level spec and wanted to add some of the URL validation detail here.

Ended up digging through the code level spec and wanted to add some of the URL validation detail here.
@thegreatfatzby thegreatfatzby changed the title Update FLEDGE.md Add Some Clarity Around the URL Validations Sep 10, 2023
FLEDGE.md Outdated Show resolved Hide resolved
Co-authored-by: Paul Jensen <[email protected]>
Copy link
Contributor

@MattMenke2 MattMenke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this looks good. Some minor suggestions.

We also have similar requirements on the corresponding seller URLs. Should we add similar verbiage there?

FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
@JensenPaul
Copy link
Collaborator

Isaac, friendly ping on this too.

FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Outdated Show resolved Hide resolved
FLEDGE.md Show resolved Hide resolved
@JensenPaul JensenPaul merged commit b04fc63 into WICG:main Apr 9, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Apr 9, 2024
SHA: b04fc63
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants