-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Some Clarity Around the URL Validations #755
Merged
JensenPaul
merged 11 commits into
WICG:main
from
thegreatfatzby:thegreatfatzby-try-clarify-url-validations
Apr 9, 2024
Merged
Add Some Clarity Around the URL Validations #755
JensenPaul
merged 11 commits into
WICG:main
from
thegreatfatzby:thegreatfatzby-try-clarify-url-validations
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ended up digging through the code level spec and wanted to add some of the URL validation detail here.
JensenPaul
reviewed
Oct 9, 2023
Co-authored-by: Paul Jensen <[email protected]>
MattMenke2
reviewed
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think this looks good. Some minor suggestions.
We also have similar requirements on the corresponding seller URLs. Should we add similar verbiage there?
Isaac, friendly ping on this too. |
dmdabbs
reviewed
Dec 8, 2023
dmdabbs
reviewed
Dec 8, 2023
dmdabbs
reviewed
Dec 8, 2023
dmdabbs
reviewed
Dec 8, 2023
dmdabbs
reviewed
Dec 8, 2023
github-actions bot
added a commit
that referenced
this pull request
Apr 9, 2024
SHA: b04fc63 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ended up digging through the code level spec and wanted to add some of the URL validation detail here.