-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec for multi-seller getInterestGroupAdAuctionData #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@qingxinwu PTAL |
qingxinwu
reviewed
Jan 24, 2025
[sad] David Dabbs reacted to your message:
…________________________________
From: brusshamilton ***@***.***>
Sent: Thursday, January 23, 2025 9:49:42 PM
To: WICG/turtledove ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [WICG/turtledove] Add spec for multi-seller getInterestGroupAdAuctionData (PR #1389)
External to the Groupe / en provenance de l'extérieur du Groupe
@qingxinwu<https://github.com/qingxinwu> PTAL
—
Reply to this email directly, view it on GitHub<#1389 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AABK3LDH2AROHGVF5KV6F7D2MFPXNAVCNFSM6AAAAABVV7TDUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJRGA4DONJRHE>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
------------------------------------------------------------------------
Disclaimer The information in this email and any attachments may contain proprietary and confidential information that is intended for the addressee(s) only. If you are not the intended recipient, you are hereby notified that any disclosure, copying, distribution, retention or use of the contents of this information is prohibited. When addressed to our clients or vendors, any information contained in this e-mail or any attachments is subject to the terms and conditions in any governing contract. If you have received this e-mail in error, please immediately contact the sender and delete the e-mail.
|
qingxinwu
reviewed
Jan 27, 2025
qingxinwu
reviewed
Jan 28, 2025
qingxinwu
reviewed
Jan 28, 2025
qingxinwu
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % the two comments
qingxinwu
reviewed
Feb 2, 2025
qingxinwu
approved these changes
Feb 4, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 4, 2025
SHA: 141d40f Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff