Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] Fix syntax errors detected by bikeshed 5.0.0 #224

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

dmcardle
Copy link
Contributor

This addresses the following errors by adding missing <div algorithm> opening tags:

LINE 1519: Saw an end tag </div>, but there's no open element corresponding to it.
LINE 1540: Saw an end tag </div>, but there's no open element corresponding to it.
LINE 1559: Saw an end tag </div>, but there's no open element corresponding to it.

Next, the following error appeared, which revealed we've been using the wrong linking syntax for this on line 1561 and in many other places.

LINE 1561: The var 'this' (in algorithm 'SharedStorageClearMethod()' for SharedStorageClearMethod) is only used once.

This addresses the following errors by adding missing `<div algorithm>`
opening tags:

    LINE 1519: Saw an end tag </div>, but there's no open element corresponding to it.
    LINE 1540: Saw an end tag </div>, but there's no open element corresponding to it.
    LINE 1559: Saw an end tag </div>, but there's no open element corresponding to it.

Next, the following error appeared, which revealed we've been using the
wrong linking syntax for `this` on line 1561 and in many other places.

    LINE 1561: The var 'this' (in algorithm 'SharedStorageClearMethod()' for SharedStorageClearMethod) is only used once.
@dmcardle
Copy link
Contributor Author

@jkarlin PTAL!

@jkarlin jkarlin merged commit d0d2cb4 into WICG:main Jan 28, 2025
2 checks passed
github-actions bot added a commit that referenced this pull request Jan 28, 2025
SHA: d0d2cb4
Reason: push, by jkarlin

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants