Update spec.bs to include operations via HTTP response header #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We update the spec to include how operations can be triggered via HTTP response headers, including by way of `fetch()` as well as HTML images and iframes.
xyaoinum
reviewed
Sep 7, 2023
|
wanderview@, PTAL. Thanks! |
xyaoinum
approved these changes
Sep 18, 2023
pythagoraskitty
requested review from
jyasskin
and removed request for
wanderview
|
@jyasskin Could you please take a look? I'm trying to get some feedback from a spec expert... thanks |
jyasskin
requested changes
Sep 20, 2023
Partially prune the anchors section
Remove 2 blank lines
Fix string and url links
Fix more anchors
change to header type dfn
Split window setter/deleter algos
string algos
jyasskin
reviewed
Sep 25, 2023
Address more comments
Add operation descriptions
|
Landing so that I can open another PR on the spec. Will continue to iterate. |
github-actions bot
added a commit
that referenced
this pull request
Sep 25, 2023
SHA: 5c06564 Reason: push, by pythagoraskitty Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jyasskin
reviewed
Sep 28, 2023
|
|
||
| This will require monkey patches to the HTML and Fetch specifications. | ||
|
|
||
| # HTML Monkey Patches # {#html-monkeypatches} |
There was a problem hiding this comment.
I'd suggest making this and the #fetch-monkeypatches section into sub-sections of the #http section. That is, add a # to all the headings you added.
|
|
||
| add the step | ||
|
|
||
| 1. If <var ignore=''>navigable</var>'s [=container=] is an <{iframe}> element, and if it has a <{iframe/sharedstoragewritable}> [=content attribute=], then set |request|'s [=request/shared storage writable=] to true. |
There was a problem hiding this comment.
You should be able to omit the ='' bit, and just use <var ignore>.
| * `key` ([=structured header/Token=], [=structured header/String=], or [=structured header/Byte Sequence=]) | ||
| * `value` ([=structured header/Token=], [=structured header/String=], or [=structured header/Byte Sequence=]) | ||
| - If the [=structured header/parameter=] value of `key` already exists in the [=shared storage database=] for the responding server's [=/origin=], then `append` updates the [=entry/key=]'s [=shared storage database/entry=]'s [=entry/value struct=]'s [=value struct/value=] by appending the [=structured header/parameter=] value for `value` to it. | ||
| - If the [=structured header/parameter=] value of `key` does not already exist in the [=shared storage database=] for the responding server's [=/origin=], `append` is equivalent to `set` with `ignore_if_present` false, i.e. `append` writes the [=shared storage database/entry=] consisting of the [=structured header/parameter=] values for `key` and `value`, as the [=shared storage database/entry=]'s [=entry/key=] and [=shared storage database/entry=]'s [=entry/value struct=]'s [=value struct/value=] respectively, in the [=shared storage database=] for the responding server's [=/origin=]. |
There was a problem hiding this comment.
I think you can omit the "with ignore_if_present false" since it's known not to be present.
| 1. If |window| is not an [=environment settings object=] whose [=global object=] is a {{Window}}, return false. | ||
| 1. If the result of running [=determine whether shared storage is allowed=] for |window| is false, return false. | ||
| 1. Let |document| be |window|'s [=global object=]'s [=associated document=]. | ||
| 1. Return the result of running [=Is feature enabled in document for origin?=] on "[=PermissionsPolicy/shared-storage=]", |document|, and |request|'s [=request/current URL=]'s [=url/origin=]. |
There was a problem hiding this comment.
This should probably use [=Should request be allowed to use feature=]? instead of "Is feature enabled...".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We update the spec to include how operations can be triggered via HTTP response headers, including by way of
fetch()as well as HTML images and iframes.Preview | Diff