Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable hydro demonstrations #65

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Variable hydro demonstrations #65

merged 10 commits into from
Sep 5, 2024

Conversation

akeeste
Copy link
Contributor

@akeeste akeeste commented Aug 22, 2024

This PR adds applications related to variable hydrodynamics.

  • working and scripted comparison between variable hydro and passive yaw. Note that BEMIO for this case may take several hours to run due to the number of .h5 files being written.
  • add a test for the variable hydro demonstration of passive yaw

Do not attempt creating this hydro data until WEC-Sim/WEC-Sim#1301 is merged

@kmruehl kmruehl self-requested a review September 4, 2024 14:25
@akeeste
Copy link
Contributor Author

akeeste commented Sep 4, 2024

The tests are currently failing because wrapTo180 is not recognized as a function. I'm not sure why this is. It doesn't appear to come with an additional toolbox. Passive yaw uses this function in pre-processing and has not thrown an error.

@H0R5E
Copy link
Contributor

H0R5E commented Sep 5, 2024

@akeeste, the products.txt file needs to go in the top level directory, i.e. Variable_Hydro/products.txt. I think the tests are failing because the toolboxes are not being installed.

@H0R5E
Copy link
Contributor

H0R5E commented Sep 5, 2024

So it ran, but the error it is creating now is:

Unrecognized method, property, or field 'variableHydro' for class 'bodyClass'.

@akeeste
Copy link
Contributor Author

akeeste commented Sep 5, 2024

So it ran, but the error it is creating now is:

Unrecognized method, property, or field 'variableHydro' for class 'bodyClass'.

Thanks @H0R5E! That fixed the issue.

This new issue is coming from this PR referencing the dev branch instead of the relevant open PR on the WEC-Sim repo. This should now pass once that PR is merged into dev. But for now this PR is serving as an working example to test that feature.

@akeeste
Copy link
Contributor Author

akeeste commented Sep 5, 2024

@kmruehl A couple more notes on this application:

  • I imagine the time required for BEMIO will stand out here. I'm really not sure how many H5 files would be required for other states (variable geometry, etc). There's a pretty wide range in direction needed here as the flap oscillates significantly in yaw about the equilibrium point (50-60 degree range in strong irregular waves). I'm hoping that other states won't require the same discretization but the pre-processing computational expense is something for us to be aware of.
  • With so many input files going into the body variable, saving that data to a .mat file makes it very very large.

@kmruehl
Copy link
Contributor

kmruehl commented Sep 5, 2024

@akeeste perhaps this case should only be run locally, or we need to greatly reduce it

@kmruehl kmruehl merged commit 34e61e7 into WEC-Sim:dev Sep 5, 2024
5 of 7 checks passed
@akeeste akeeste deleted the variableHydro branch September 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants