Arevyn assignment9 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still needs work. I need to add the output to a file and finish the test method.
I kept changing stuff with this all week. I think I'm finally ready (and about out of time) to post as a pull request.
| dieList.add(new LoadedDie(sides, loadedSide)); | ||
| break; | ||
| } // end switch | ||
| } // end foreach die loop |
There was a problem hiding this comment.
What happens if someone throws in a die that's not "numbered", "fudge", or "loaded"?
There was a problem hiding this comment.
It looks to me that loaded is handled by the default case that is risky
There was a problem hiding this comment.
I see what you mean. Looking back now, I'm not sure why I set it up that way. Will have that fixed soon.
|
Very well designed and I liked how you thought through with the input/output files. |
|
Really like your commenting, especially the ones that designate what the }'s are for. Makes it very easy to follow nested structures when they are commented like that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I think I'm finally done. Still needs work but it's completed, at least.