Initial Commit #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial push, for desk checking and trouble shooting purposes,
| // Put you read logic and populate lines | ||
| while (this.input.hasNext()) { | ||
| String line = this.input.nextLine(); | ||
| if (line.charAt(0) != '#') { // excludes commented header lines |
Bloody typo's and ; 's will get you everytime.
Ta Da!
|
|
||
| // seperate the file's line into die | ||
| for (int ii = 0; ii < fileLine.length; ii++) { | ||
| String[] dieConfig = fileLine[ii].split(":"); |
There was a problem hiding this comment.
I like the use of i and ii in your for loops. A third nested loop could use iii, I would assume. It kinda ties them together and tells you where in the loops you are. I think I'm going to steal your idea. :-)
Program works and writes output to a file. I left it so the program will also print to the IDE, easier for checking results. I feel like it could have been broken down further even into more objects or methods.
Rewrote Try Catch statement to enclose only the statement and not the block
| } | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
I had so much trouble with this assignment. Your setup made the most sense to me. I tried to follow your flow, but I still could not get mine to run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial push, for desk checking and trouble shooting purposes,